Menu
▾
▴
[MinGW-notify] [ mingw-Patches-2817021 ] ^C (CONTROL+C) ignored when CYGWIN=tty set
|
From: SF/projects/mingw n. l. <min...@li...> - 2013-01-13 21:26:43
|
Patches item #2817021, was opened at 2009-07-05 10:54 Message generated for change (Comment added) made by cstrauss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2817021&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: msys Group: None >Status: Closed >Resolution: Invalid Priority: 5 Private: No Submitted By: bughunter2 (bughunter2) Assigned to: Cesar Strauss (cstrauss) Summary: ^C (CONTROL+C) ignored when CYGWIN=tty set Initial Comment: Problem: When CYGWIN=tty is set, and we invoke the MSYS shell like this: `sh -c "/bin/sh"' Then, pressing ^C (CONTROL+C) inside that shell has no effect. While pressing CONTROL+BREAK does yield the expected effect. Details: It is related to the TTY initialization code from CYGWIN. The proposed patch fixes this problem by setting the ENABLE_PROCESSED_INPUT flag (from the Win32 API) so that (I quote MSDN here) "CTRL+C is processed by the system and is not placed in the input buffer.". Please consider the attached patch. ---------------------------------------------------------------------- >Comment By: Cesar Strauss (cstrauss) Date: 2013-01-13 13:26 Message: The real issue is that the CYGWIN variable should not be allowed to affect MSYS. See: Bug #3600715: https://sourceforge.net/tracker/?func=detail&aid=3600715&group_id=2435&atid=102435 Meanwhile, please clear the CYGWIN variable when using MSYS. Also, the tty option was dropped on Cygwin, and likely is not useful in MSYS as well. See: The CYGWIN environment variable http://cygwin.com/cygwin-ug-net/using-cygwinenv.html "(no)tty - If set, Cygwin enabled extra support (i.e., termios) for UNIX-like ttys in the Windows console. This option has been removed because it can be easily replaced by using a terminal like mintty, and it does not work well with some Windows programs." Thanks, Cesar ---------------------------------------------------------------------- Comment By: bughunter2 (bughunter2) Date: 2009-07-12 14:30 Message: A Cygwin developer told me he checked in a fix for this issue, see [ http://sourceware.org/cgi-bin/cvsweb.cgi/winsup/cygwin/sigproc.cc.diff?cvsroot=uberbaum&r1=1.313&r2=1.314 ]. This may or may not fix the issue for MSYS. ---------------------------------------------------------------------- Comment By: bughunter2 (bughunter2) Date: 2009-07-12 14:04 Message: I've contacted Cygwin developers on the issue. They made a good point about the interrupt character not always being set to ^C, so this patch wouldn't work for every case (at least not for Cygwin, where the TTY mode is still supported). BUT, perhaps this patch is not even relevant to MSYS (judging by earnie's comment). ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2009-07-06 07:04 Message: I don't know that this should be accepted. I'll let Cesar decide. The documentation states that the CYGWIN environment variable should not be set. Perhaps the correct fix would be to remove the CYGWIN variable on initialization. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=2817021&group_id=2435 |
