Recent changes to bugs

Pressing enter does nothing (have to click to submit form)

Anonymous — Thu, 18 Mar 2010 13:28:40 -0000

Somehow adding this javascript is preventing me simply typing in a string and pressing return which ought to be the default behaviour.

Nothing happens

Silvio Waters — Sat, 08 Aug 2009 07:24:46 -0000

I have set up the search suggestor on my input box, created a php file and added it as the action.

I have manually tested the output of my php page and does infact output values.

print utf8_encode("new Array(" . implode(", ", $values) . ");"); //last line.

HTML:

<input class="inputbox" title="MaFia DDL Search" name="q" id="q" onfocus="clearBox(this.value);" onblur="resetBox(); fill();" autocomplete="off" value="<?php if (isset($_REQUEST['q'])) echo $_REQUEST['q']; else echo 'Enter Search Keywords'; ?>" action="include/suggest.php" columns="1" delay="1000" />

This is on my main index page:

When entering a search query i get no suggestions. Anys ideas? Or suggestions on what i can do to figure out what the issue at hand is?

do not show heading when heading="true"

qxo — Sat, 29 Apr 2006 07:18:59 -0000

This bug in here:
function sfwSuggest(instance, list)
{
//...
var heading = sfw[instance].suggestions.shift();
//...
}

function sfwShowOutput(instance)
{
if(typeof sfw[instance].suggestions != "undefined" &&
sfw[instance].suggestions.length){
sfw[instance].outputContainer.style.display = "block";
}
};

when list.length =1 and heading=true
now if just have sfw[instance].suggestions.length =0
so the result can not show.

Different ID and Name

Anonymous — Mon, 10 Apr 2006 07:59:30 -0000

If the input element's ID is different from name, the
suggest framework will not work.

On select of entry launch another function

Anonymous — Sat, 08 Apr 2006 18:05:27 -0000

I have used the suggest framework to look up companies
from a database of several thousand and it works
well. However I would like to take an action after
the final value is selected and so would like to
launch another script function. All would be fine if
some browsers supported the onchange event correctly,
but they don't!

my email is mike@jupps.co.uk

thanks for your time

Mike Jupp

Line Break behind the Input Field

Anonymous — Sat, 01 Apr 2006 09:02:19 -0000

Hey Guys,
I got a small Problem with the use of the script. In my
form, where i want to use the script, are three fields
aligned in one line.

[Field1 with Manual Input] [Field2 with Suggest-Script
] [Field3 with Manual Input]

It works, but the Layout creates a new line after the
second field. It seems, that the "action="backend.php"
cases the new line. After removing this Tag, it looks
good, but it didnt work anymore ;) How can i prevent
the Script off making a new line after the Ajax-Field,
so that it works?

Please help :) stephan@phreakadelle.de

bug or not

Ilyas Bakirov (aka eRIC) — Fri, 23 Sep 2005 07:37:10 -0000

I tested your example for my JSP and database to
retreive some results. i tested it on FireFox and i
didn't work because backend file has some errors. when
i fixed it it worked. i think file that is on this
project site has errors. i attached the file which
worked for me. please check it.

Array looping bug with \"var in\"

Dennis Kline — Mon, 19 Sep 2005 14:01:41 -0000

This isn't a bug within SuggestFramework itself, but if
this library would like to play nicely with others,
then there is a small problem.

If another library adds functions to Array, then
looping using "var in" will iterate over the additional
properties as well as the elements within.

The fix for this is fairly straightforward: we just
need to replace the loops using "var in" to "var i = 0
...".

The function needing our attention is:

function SuggestFramework_Suggest(instance, list)

Since the original code is easily accessable inside of
sourceforge, i will only include the "fix" as pasted below:

<snip>
for(var i = 0; i <
SuggestFramework_Suggestions[instance].length; i++)
{
var suggestionContainer = '<tr id="' +
SuggestFramework_Name[instance] + 'Suggestions[' +
SuggestFramework_Suggestions[instance][i] + ']">';

for(var j = 0; j <
SuggestFramework_Columns[instance]; j++)
{
var value =
((SuggestFramework_Columns[instance] > 1) ?
(SuggestFramework_Suggestions[instance][i])[j] :
SuggestFramework_Suggestions[instance][i]);
var column = '<td
class="SuggestFramework_Normal"';
if(SuggestFramework_Columns[instance] > 1
&& j == SuggestFramework_Columns[instance] - 1)
column += ' style="text-align: right"';
column += '>' + value + '</td>';
suggestionContainer += column;
}
suggestionContainer += '</tr>';
table += suggestionContainer;
}
tbody += '</tbody>';
table += tbody;
table += '</table>';

SuggestFramework_OutputContainer[instance].innerHTML =
table;
for(var i = 0; i <
SuggestFramework_Suggestions[instance].length; i++)
{
var row =
document.getElementById(SuggestFramework_Name[instance]
+ 'Suggestions[' +
SuggestFramework_Suggestions[instance][i] + ']');
row.onmouseover = new
Function("SuggestFramework_Highlight(" + instance + ",
" + i + ")");
row.onmousedown = new
Function("SuggestFramework_SelectThis(" + instance + ",
" + i + ")");
}

</snip>

Thanks,
-Dennis Kline

code improvement

Massimiliano Arione — Thu, 15 Sep 2005 14:47:40 -0000

This is not actually a bug, just a suggestion to
improve the code.
It would be better to use tr classes instead of td classes.
It's quite overkilled to class every single td of a
row, when you can simply class the row (and, of course,
the tds contained in that row).
I'm not an advanced javascript coder, but I guess that
some time could be saved by avoiding cycles for all tds...

CSS will look like this:

tr.SuggestFramework_Highlighted td

{

padding: 0 1px 0 1px;

background-color: Highlight;

color: HighlightText;

}

tr.SuggestFramework_Normal td

{

padding: 0 1px 0 1px;

background-color: #FFFFFF;

color: #000000;

}

Sorry, I'm not able to suggest a javascript code.

unvalid HTML code

Massimiliano Arione — Thu, 15 Sep 2005 13:46:00 -0000

The way to pass parameters using attributes of tag
<input> is definitively unvalid.
It would be better to use some kind of javascript
variables configuration for action, capture, columns, etc.
Otherwise, HTML code will never pass w3c validation.