Recent changes to 23: sispm_switch_on should check outlet state

#23 sispm_switch_on should check outlet state

xypron — Sun, 18 Nov 2018 15:18:02 -0000

status: open --> accepted
assigned_to: xypron

#23 sispm_switch_on should check outlet state

Pete Hildebrandt — Sun, 03 Sep 2017 20:49:17 -0000

Thanks for the patch. I will have a look at it :)

#23 sispm_switch_on should check outlet state

RichardEberhard — Sun, 03 Sep 2017 10:03:51 -0000

I made a patch file.

sispm_switch_on should check outlet state

RichardEberhard — Sat, 02 Sep 2017 09:19:15 -0000

Hello,

the internal functions sispm_switch_on and sispm_switch_off should check the state of the outlet before sending the usb action.

If I call the "sispmctl -o 1" command frequently on an already active outlet it can happen that the relay(outlet) turns off(or fails?)

To prevent this and also to prevent unecessary usb commands, the code should check the state of the outlet before sending the command.

In addition to this it is more efficent to do the check in the program directly.

Checking the state in a third party application would require to start the program two times and two times parsing the output. Starting a program creates a lot of overhead.

So I would highly request such a check in your software.

Thank You

sispm_switch_on should check outlet state

RichardEberhard — Sat, 02 Sep 2017 09:19:15 -0000

Ticket 23 has been modified: sispm_switch_on should check outlet state
Edited By: xypron (xypron)
Status updated: u'open' => u'accepted'
Owner updated: None => u'xypron'