Recent changes to bugs

Adding ignored packages does not work

2012-07-06T13:17:15Z

Hello

Adding ignored packages using the addIgnoredPackages() method does not actually add anything, as it doesn't update the array field.
Consider the current implementation of the method

protected transient String[] ignoredPackages = {"javax", "java", "sun", "com.sun", "javassist"};

public void addIgnoredPackages(String... ignored)
{
String[] tmp = new String[ignoredPackages.length + ignored.length];
int i = 0;
for (String ign : ignoredPackages) tmp[i++] = ign;
for (String ign : ignored) tmp[i++] = ign;
}

It's clearly visible that the new packages are not added to the ignoredPackages.

Cheers
Mladen

Patch to fix 6 outstanding bugs and add white list API

2011-03-01T21:21:56Z

Attached is a patch that fixes the following bugs:
ID: 3011026 - NPE when WEB-INF/lib does not exist
ID: 2864003 - packages not ignored when class files in a directory
ID: 2863974 - adding an ignored package might not work
ID: 2126527 - Scanning of classes not disable able
ID: 1922942 - org.scannotation.AnnotationDB class

In addition it adds the following APIs to allow white-listing of scanned packages:

/**
* Set explicit packages to scan.
* Set to null to enable ignore list.
*
* @param scanPackages packages to scan or null
*/
public void setScanPackages(String[] scanPackages)
public String[] getScanPackages()

How about a 1.0.3 release Bill?

FileProtocolIteratorFactory creates File from a URL wrong

2010-12-10T19:17:18Z

Line 17 of FileProtocolIteratorFactory.java creates a File from the output of URL#getPath(). If the URL in question has, for example, %20 in it, this will produce a File that is probably not what you want.

Kohsuke Kawaguchi has an excellent article on this very problem: http://weblogs.java.net/blog/2007/04/25/how-convert-javaneturl-javaiofile

The attached patch against the trunk from the root applies this solution (as well as increments the POM version).

Thanks for an excellent little library; it's saved my bacon several times.

NPE when WEB-INF/lib does not exist

2010-06-03T13:47:27Z

Scannotation fails with NPE if a web archive does not contain the WEB-INF/lib folder (no libraries bundled with the app)

org.scannotation.WarUrlFinder.findWebInfLibClasspaths(WarUrlFinder.java:27)

Tested on scannotation 1.0.2 (RESTEasy 2.0-BETA3-SNAPSHOT)

packages not ignored when class files in a directory

2009-09-22T03:49:56Z

AnnotationDB.ignoreScan(String intf)
when scanning files in a directory intf contains the class filepath, thus never starts with ignored packages.
As an example:
intf = "D:\Workspace\MyProject\bin\com\mypackage\MyClass.class"
ignored packages = {"org", "sun""}

adding an ignored package might not work

2009-09-22T03:05:03Z

tmp is not written back to this.ignoredPackages
public void addIgnoredPackages(String... ignored)
84 {
85 String[] tmp = new String[ignoredPackages.length + ignored.length];
86 int i = 0;
87 for (String ign : ignoredPackages) tmp[i++] = ign;
88 for (String ign : ignored) tmp[i++] = ign;
89 }

Scanning of classes not disable able

2008-09-24T14:30:56Z

In AnnotationDB the semicolon at the end of line 313 is too much so scanClass() is always called.

312 classIndex.put(cf.getName(), new HashSet<String>());
313 if (scanClassAnnotations) ;
314 scanClass(cf);

problem with directory containing spaces

2008-07-28T15:06:32Z

If the path contains spaces the FileProtocolIteratorFactory will not work because in new File(url.getPath()) the spaces get passed in as %20.

Attached a possible fix.

Jan

org.scannotation.AnnotationDB class

2008-03-22T10:49:51Z

In "addIgnoredPackages(String... ignored)" method of "org.scannotation.AnnotationDB" class, isn't something like "this.ignoredPackages = tmp;" missing (line 89)?