Recent changes to bugs

It get confused with directories with same name.

2004-05-02T16:34:25Z

If there are two or more directories with the same name
(of the same user) the addon return always the first
found in the SQL dateien table.

For example, if there is a directory like this:
/mydir/test/test2/test/
whenever you try to enter the second "test" directory
you get the content of the first one (including its
test2 directory). You get something like this:
/mydir/test/test2/test/test2/

You can go on forever browsing inside these "virtual"
directories. Actually, if you try to copy recursively
the /mydir/test/ directory, the Windows Explorer (for
example) just hang there, asking for deeper and deeper
directories (I only waited until it went for the 108th
directory). This is not a fault of Win Explorer, as the
PHP script just tell it that there are more and more
directories inside.

The problem, I think, is with the _path_id function in
class_webdav.php which only search for the
filename/dirname in the SQL database table without
really checking if the parent of the directory is the
requested one (even though it has the necessary
information [the full path]).

I think the _path_id function should recurse checking
for the parent of each matching filename/dirname. I
think this can be done from the outer leaf to the root
or viceversa, anyway it should check the full path, not
just the immediate parent.

In Phprojekt filename/dirname selection and checking is
easier, because there is always an ID associated with
the filename/dirname in every form or link. But in this
case I think the only solution is to walk the possible
branchs until a match is found.

I hope what I have said make some sense. :)

Mario A. Valdez-Ramírez.

Cannot create directories in first-level dir.

2004-05-02T14:37:24Z

If you try to create a directory in the root directory
(/phptojekt/webdav.php/ or whatever) the webdav addon
refuse to create the directory. This is not a problem
if the directory is created in an already existing
directory.

Webdav MKCOL requests on the first-level directory are
answered with a 409 status code (409 = Conflict).

According to RFC 2518 this error code if to be issued
when the client request that a directory be created
but the intermediate directories don't exist. For
example, if the client request /maindir/adir/bdir/ but
/maindir/adir/ don't exist, the server must answer with
a 409.

The function MKCOL in class_webdav.php calls function
_path_id to find out if the path of the collection
(directory) to be created already exist. If the
directory is / then it returns 0. The MKCOL function
just test the return value ($pid) for non-zero. So, the
condition doesn't disguise between a non-existant
directory and the root directory.

As a quick workaround, I changed the condition at lines
255 or so:

if (!$pid) {
return '409 Confilct';
}

I changed them to this:

if (!$pid) {
if ($pid !== 0) {
return '409 Confilct';
}
}

However, I hope the author can comment on this, maybe
I'm breaking something.

Mario A. Valdez-Ramírez.

UNIX_TIMESTAMP is a MySQL-only non-standard function.

2004-05-02T11:38:00Z

In the file class_webdav.php, at line 448 or so, the
SQL statement reads:

SELECT UNIX_TIMESTAMP(datum)...

unix_timestamp is non-standard, and other SQL engines
don't understand it (or have different function names).

The datum field stores the file time/date upload time
in a yyyymmddhhmmss format, just like a mysql timestamp
column. However, you cannot rely on mysql functions to
manage this if the addon is going to support all SQL
backends of Phprojekt.

A solution is to extract the datum field as is, and
then convert it in the PHP space. For example, the SQL
statement would be:

SELECT datum, typ, filesize, tempname, ID, pw...

and then convert the datum field to epoch time and
store it in a variable:

$unix_timestamp = mktime(substr($row[0],8,2),
substr($row[0],10,2), substr($row[0],12,2),
substr($row[0],4,2), substr($row[0],6,2),
substr($row[0],0,4));

and then store the values in the return array:

return array('mdate' => date ('U', $unix_timestamp),
'cdate' => date ('U', $unix_timestamp)...

(maybe the date function is redundant).

Regards,

Mario A. Valdez-Ramírez.

Single quotes in SQL strings dont work in PostgreSQL.

2004-05-02T10:51:08Z

All SQL strings in class_webdav.php use single-quoted
strings (for the parameters, not the sql string). They
cause an error like this in PostgreSQL:
query failed: ERROR: attribute 'root' not found

For example, the login SQL string is:
'SELECT ID, pw, gruppe FROM '.WD_TAB_USER. ' WHERE
'.$field_name.'="'.$user.'"'

but I have to change it to:
'SELECT ID, pw, gruppe FROM '.WD_TAB_USER. ' WHERE
'.$field_name.'=\''.$user.'\''
to make it work in PostgreSQL.

As far as I know, in PostgreSQL single-quotes are used
to delimit string constants, while double-quotes are
used to delimit identifiers (called delimited
identifiers) such as column names or table names.

In Phprojekt all SQL strings are sorrounded by
double-quotes but individual parameters are enclosed
using single-quotes. That may be a definitive solution
that would work with all DB back-ends supported by
Phprojekt. So, for example, the login SQL string would
become:

"SELECT ID, pw, gruppe FROM ".WD_TAB_USER. " WHERE
".$field_name."='".$user."'"

Mario A. Valdez-Ramirez.

Syntax error in 0.5

2004-05-02T10:34:11Z

Error at line 78 of class_webdav.php:
$pass = addlsashes($pw);
should read:
$pass = addslashes($pw);

Mario A. Valdez-Ramirez.

Error while uploading files with Windows

2004-01-19T00:51:38Z

After uploading files to the Server Windows reports an
error. After reloading the folder the files are available.

Login with data stored in LDAP isn't pssible

2004-01-19T00:49:37Z

When PHProjekt is running using LDAP there is no way to
login with WebDAV for PHProjekt.