Recent changes to bugs

par.exe generates corrupt PAK files on Windows

2006-11-09T19:04:20Z

The build outputs corrupt PAK files on Windows. The
Quake engines do their best to load the file and don't
emit clear diagnostics. The result is Quake simply
doesn't run with the PAK files that user's build on
their own.

The root cause of the problem is that par.c assumes
that off_t is a four byte value. On my Windows box and
with my version of gcc, off_t is an eight byte value.

I'm using gcc:

gcc (GCC) 3.4.4 (cygming special) (gdc 0.12, using dmd
0.125)

par.c should be fixed such that.

How Reproducible:
Every Time (when you have a strange gcc)

Steps to Reproduce:
1) par -c test.pak file1 file2
2) par -l test.pak

What Happens:
The second par command complains that test.pak is corrupt.

Expected Result:
The second par command says that test.pak contains
file1 and file2.

box.map has leak -- vis and light won't run

2004-09-26T20:24:10Z

box.map has a leak in it making it so that box.bsp
can't be compiled properly. The box.bsp that is
generated does not have any lighting or visibility
clipping information associated with it. This means it
runs "fullbright" and very slowly.

box.bsp is included in our pak files, so this also
means that our build is broken. However, since a bad
box.bsp is created, re-running gmake will succeed, but
the bad box.bsp will be compiled into our pak files.

Steps to Reproduce:
1) cd pak0
2) rm maps/box.bsp
3) gmake maps/box.bsp

What Happens:
The build reports an error. maps/box.bsp is created,
but it runs full-bright and very slowly. The output
from gmake follows:

../utils/qutils/bin/qbsp maps/box.map
---- qbsp ---- (Aug 12 2004)
Original source from id software
portions copyright Alexander Malmberg
<alexander@malmberg.org>

This version of qbsp supports detail brushes and will
only work with versions
of vis that support detail brushes.

This version of qbsp also supports HINT and SKIP brushes.
--------------
qdir: /home/dcostanz/openquartz-CVS/pak0/maps/
gamedir: /home/dcostanz/openquartz-CVS/pak0/maps
outputfile: maps/box.bsp
--- LoadMapFile ---
maps/box.map
677 brushes (0 detail)
160 entities
7 miptex
217 texinfo
building hulls sequentially...
--- Brush_LoadEntity ---
661 brushes read
---- CSGFaces ----
4702 brushfaces
12275 csgfaces
2230 mergedfaces
----- SolidBSP -----
4342 split nodes
2115 solid leafs
2228 empty leafs
0 water leafs
7305 leaffaces
6956 nodefaces
----- portalize ----
----- FillOutside ----
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
reached occupant at: (-1850,-2876, 48)
classname: 'monster_knight'
no filling performed
leak file written to maps/box.pts
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
MODEL: *1
MODEL: *2
MODEL: *3
MODEL: *4
MODEL: *5
MODEL: *6
MODEL: *7
MODEL: *8
MODEL: *9
MODEL: *10
MODEL: *11
MODEL: *12
MODEL: *13
MODEL: *14
MODEL: *15
MODEL: *16
--- FinishBSPFile ---
WriteBSPFile: maps/box.bsp
added 0 texture frames
946 planes 18920
7332 vertexes 87984
3252 nodes 78048
217 texinfo 8680
6773 faces 135460
8574 clipnodes 68592
2073 leafs 58044
6946 marksurfaces 13892
26872 surfedges 53744
17177 edges 68708
7 textures 105032
lightdata 0
visdata 0
entdata 12650
9.6 seconds elapsed
../utils/qutils/bin/vis maps/box.bsp
---- vis ----
LoadPortals: couldn't read maps/box.prt
No vising performed.
make: *** [maps/box.bsp] Error 1

What Should Happen:
maps/box.bsp should be compiled with no errors. It
should have lighting info and have an acceptable framerate.

par utility does not compile on windows

2004-08-13T05:54:02Z

The "par" utility does not compile on windows.

There are a few problems. One is that par uses UNIX
system calls (open, write, close, lseek, mkdir, etc),
which are not part of Windows. The file operations
could be re-written to use ANSI C file functions in
stdio.h. We could use a #define to replace mkdir with
_mkdir() on windows.

The other problem is that "par" calls system("rm -f")
to clean up on error. I think this can be replaced
with the ANSI C remove().

Even though there are friendlier PAK utilities for
Windows, this is somewhat important because par is part
of our automated build process and it would be nice if
our build system were platform-independent.

mkwad does not compile on windows - mingw

2004-08-13T05:31:14Z

The mkwad utility does not compile on Windows under
mingw. It is missing fnmatch.h and fnmatch(), which is
a UNIX-only function (or maybe GNU-only).

I poked around on the Web and it looks like GTK
overcomes this problem by including the original
fnmatch.c (from glibc) in their source tree. I think
we should do the same (assuming that mkwad is GPL).

I have given this a priority of "lowest" because our
build currently does not use mkwad and because there
are friendlier tools for Windows.

mkwad crashes when "wildcard" parameter is missing

2004-08-12T06:50:05Z

Open Quartz's WAD management tool crashes when given a
bad set of command-line parameters. Instead, it should
display a help message.

Specifically, mkwad crashes when run in "r" mode (list
contents) without being given a wildcard match target.

On a side note, I think mkwad should display the help
message whenever it is given command-line parameters
that it doesn't recognize. For example, none of the
following are legal, but none cause mkwad to display
the usage message.

mkwad --help
mkwad read mywad '*'
mkwad mywad extract

Steps to Reproduce Crash:
1) Go to the directory where utils and pak0 are checked out
2) Run "utils/bin/mkwad r pak0/maps/textures/free_wad.wad"

What Happens:
mkwad segmentation faults

What Should Happen:
mkwad displays the usage message.

pak0 module can't compile b_batt0.bsp - missing QuArK.wad

2004-08-01T04:57:02Z

The pak0 module in CVS can't compile b_batt0.bsp.

Running "make" in the pak0 module does build pak files
that includes b_batt0.bsp (because b_batt0.bsp is
included in CVS), but it cannot build b_batt0.bsp by
itself, because a necessary file -- QuArK.wad -- is not
part of the distribution. Moreover, I cannot find
QuArK.wad in my version of QuArK or anywhere on the
Internet.

While b_batt0.bsp may not be important, I think this
error is keeping away potential contributors. I have
seen posts to this in the openquartz-general mailing
list of people asking for help on this. I, myself,
would have joined the project a year ago, but I
encountered this error and didn't know how to continue.

Note that b_batt0.bsp isn't the only bsp that can't be
compiled. It's just the first one that "make"
complains about.

The output from "make maps/b_batt0.map" follows:

../utils/qutils/bin/qbsp maps/b_batt0.map
---- qbsp ---- (Jul 29 2004)
Original source from id software
portions copyright Alexander Malmberg
<alexander@malmberg.org>

This version of qbsp supports detail brushes and will
only work with versions
of vis that support detail brushes.

pak files built from CVS don't run - no maps/start.bsp

2004-07-22T08:25:48Z

The CVS "pak0" module build into two files: pak0.pak
and pak1.pak. When these file are copied into the
"id1" directory of a quake executable, the game won't
run the single player game. Instead, I get the
following error dialog box:

Couldn't load map 'maps/start.bsp'

The last few lines of console output are:

> "maxplayers" set to "1"
> FS_FindFile: can't find maps/start.bsp
> Couldn't load map maps/start.bsp
> FS_FindFile: sound/misc/menu1.wav in ./id1/pak0.pak

maps/start.bsp is built, it's just not included in
pak0. If I add maps/start.bsp to "pak0.pak.files", the
game runs, but it's noticable different from the
pre-packaged version called
OpenQuartzLinux2004.07.11.tar.gz. At the very least,
there are no dragon monsters in the game built from
CVS. Another big difference is that the pre-packaged
version has four pak files, whereas the CVS snapshot
only builds two.

Some programs in "utils" module don't compile

2004-07-21T08:05:42Z

On GNU/Linux with GCC 3.3.3, there are a few utilities
in the "utils" module that don't compile (from CVS).
Here are the error messages.

mesh2map

"knoppix@box:~/temp/oq/cvs/utils/mesh2map$ make
cc -o ../bin/mesh2map -O2 -Wall -W mesh2map.c
mesh2map.c: In function `clean_up':
mesh2map.c:92: warning: control reaches end of non-void
function
mesh2map.c: In function `write_brush':
mesh2map.c:396: warning: control reaches end of
non-void function
mesh2map.c: In function `convert':
mesh2map.c:446: warning: too many arguments for format
mesh2map.c:403: warning: `m' might be used
uninitialized in this
function
mesh2map.c:404: warning: `materials' might be used
uninitialized in
this
function
mesh2map.c: In function `main':
mesh2map.c:641: warning: unused variable `count'
/tmp/ccfpsRhx.o(.text+0x1bd): In function `get_normal':
: undefined reference to `sqrt'
/tmp/ccfpsRhx.o(.text+0xc7f): In function `write_brush':
: undefined reference to `asin'
/tmp/ccfpsRhx.o(.text+0xcdf): In function `write_brush':
: undefined reference to `asin'
/tmp/ccfpsRhx.o(.text+0xe97): In function `write_brush':
: undefined reference to `asin'
/tmp/ccfpsRhx.o(.text+0x1078): In function `write_brush':
: undefined reference to `sqrt'
/tmp/ccfpsRhx.o(.text+0x114d): In function `write_brush':
: undefined reference to `sqrt'
/tmp/ccfpsRhx.o(.text+0x1172): In function `write_brush':
: undefined reference to `sqrt'
/tmp/ccfpsRhx.o(.text+0x118f): In function `write_brush':
: undefined reference to `sqrt'
/tmp/ccfpsRhx.o(.text+0x1256): In function `write_brush':
: undefined reference to `sqrt'
/tmp/ccfpsRhx.o(.text+0x1272): more undefined
references to `sqrt'
follow
collect2: ld returned 1 exit status
make: *** [../bin/mesh2map] Fehler 1"

mdl2map:

knoppix@box:~/temp/oq/cvs/utils/mdl2map$ make
gcc -o ../bin/mdl2map main.o mdl.o map.o csendian.o
main.o(.eh_frame+0x12): undefined reference to
`__gxx_personality_v0'
mdl.o(.text+0x193): In function `Mdl::~Mdl [in-charge
deleting]()':
: undefined reference to `operator delete(void*)'
mdl.o(.text+0x1e3): In function `Mdl::setError(char*)':
: undefined reference to `operator delete(void*)'
mdl.o(.text+0x4ad): In function `Mdl::ReadMDLFile(char*)':
: undefined reference to `operator new[](unsigned)'
mdl.o(.text+0x536): In function `Mdl::ReadMDLFile(char*)':
: undefined reference to `operator new[](unsigned)'
mdl.o(.text+0x550): In function `Mdl::ReadMDLFile(char*)':
: undefined reference to `operator new[](unsigned)'
mdl.o(.text+0x5db): In function `Mdl::ReadMDLFile(char*)':
: undefined reference to `operator new[](unsigned)'
mdl.o(.text+0x676): In function `Mdl::ReadMDLFile(char*)':
: undefined reference to `operator new[](unsigned)'
mdl.o(.text+0x6b0): more undefined references to `operator
new[](unsigned)' follow
mdl.o(.gnu.linkonce.d._ZTI3Mdl+0x0): undefined
reference to `vtable for
__cxxabiv1::__class_type_info'
mdl.o(.eh_frame+0x11): undefined reference to
`__gxx_personality_v0'
map.o(.text+0x4a): In function `WriteMAP(char*, Mdl,
float, float,
float, float, float)':
: undefined reference to `operator new[](unsigned)'
map.o(.text+0xd7): In function `WriteMAP(char*, Mdl,
float, float,
float, float, float)':
: undefined reference to `operator new[](unsigned)'
map.o(.text+0xf0): In function `WriteMAP(char*, Mdl,
float, float,
float, float, float)':
: undefined reference to `operator new[](unsigned)'
map.o(.text+0x22d): In function `WriteMAP(char*, Mdl,
float, float,
float, float, float)':
: undefined reference to `operator new[](unsigned)'
map.o(.text+0x254): In function `WriteMAP(char*, Mdl,
float, float,
float, float, float)':
: undefined reference to `operator new[](unsigned)'
map.o(.text+0x471): more undefined references to `operator
new[](unsigned)' follow
map.o(.eh_frame+0x12): undefined reference to
`__gxx_personality_v0'
collect2: ld returned 1 exit status
make: *** [../bin/mdl2map] Fehler 1

raw2map

knoppix@box:~/temp/oq/cvs/utils/raw2map$ gcc -Wall
raw2map.c
raw2map.c: In function `write_block':
raw2map.c:72: warning: control reaches end of non-void
function
raw2map.c: In function `convert':
raw2map.c:148: warning: int format, long int arg (arg 2)
raw2map.c: In function `main':
raw2map.c:407: warning: implicit declaration of
function `strncasecmp'
/tmp/ccLwXY5q.o(.text+0xa45): In function `convert':
: undefined reference to `sqrt'
collect2: ld returned 1 exit status

toon

knoppix@box:~/temp/oq/cvs/utils/toon$ gcc -Wall toon.c
toon.c: In function `clean_up':
toon.c:79: warning: control reaches end of non-void
function
toon.c: In function `write_outline_mesh':
toon.c:180: warning: control reaches end of non-void
function
toon.c: In function `convert':
toon.c:237: warning: too many arguments for format
/tmp/ccq1gCCR.o(.text+0x7a0): In function
`write_outline_mesh':
: undefined reference to `sqrt'
/tmp/ccq1gCCR.o(.text+0x993): In function
`write_outline_mesh':
: undefined reference to `sqrt'
collect2: ld returned 1 exit status