Recent changes to bugs

Reference to Queue class is ambiguous

2005-01-24T06:26:00Z

I was using Java 1.5. It has java.utill.Queue which
conflicts with salvo.jesus.util.Queue. The error I got is

.\salvo\jesus\graph\algorithm\BreadthFirstTraversal.java:19:
reference to Queue is ambiguous, both class
salvo.jesus.util.Queue in salvo.jesus.util and class
java.util.Queue in java.util match
private Queue queue;

when I tried with jdk 1.4 it worked fine

Regards,
Jayesh Jain

jjjain@buffalo.edu

Class Cast Exception in LayeredTreeLayout

2003-08-06T13:15:04Z

on Linux (redHat 8):

This bug happens when you push the Layout button with
a tree loaded from a File.

How to reproduce the bug:
Build a Tree through a java class (i.e let's consider
the SampleTreeLayout class).
Save it as "tmp.xgmml".
Push the Layout button>>everything is ok

Now, open the file you just saved: "tmp.xgmml".
Push the Layout button
You'll get a Class Cast exception:

This happens 'cause there's a casting from Graph to Tree:

"tree=(Tree) this.vgraph.getGraph();"

This instruction is totally safe when the Tree is
builded from an external class (i.e SampleTreeLayout),
but it gives a systematic Class Cast Exception if the
Tree is builded from an xgmml file...

Loading edge labels from XGMML

2003-05-14T16:44:00Z

Using 0.9.2, it looks like edge labels aren't being loaded
from XGMML files.

Changing XGMMLContentHandler::instantiateEdge() to
check for a label attribute, and if defined, call both
setLabel() and setFollowVertextLabel( false ) correctly
loads the label.

I've attached a tarball that includes both an example
XGMML file that isn't loaded correctly in 0.9.2, and the
modified XGMMLContentHandler.java which will load the
edge labels.

compileall.sh doesn't work on tcsh

2003-02-19T13:09:09Z

There is a small typo in the first line of
compileall.sh preventing it from running correctly.
Correction is appended

wrong usage of == for object comparison

2002-06-28T01:06:29Z

In salvo.jesus.graph.EdgeImpl class getOppositeVertex(
Vertex v ) method uses the == for object comparison. I
think we should use "equals" method for correct results.

parsing of xgmml element <graph>

2002-02-11T13:43:49Z

When trying to load a simple XGMML document from
within the editor a NullPointerException is raised in
salvo.jesus.graph.xml.XGMMLContentHandler.startGraphEle
ment(XGMMLContentHandler.java:153).

The problem seems to be that XGMMLContentHandler
expects a "Graphic" attribute in the <graph> element.
According to the specification
(http://www.cs.rpi.edu/~puninj/XGMML/draft-
xgmml.html#GraphA) this attribute is optional
(#IMPLIED).

I have verified this with the two first sample
documents given in the XGMML Draft Specification
(http://www.cs.rpi.edu/~puninj/XGMML/draft-
xgmml.html#StructXGMMLDoc).

Graph.createEdge - deprecation warning

2002-01-24T23:30:17Z

The deprecation warning for Graph.createEdge() is
caused in the graph package even if one of the
implementation classes in the graph package is
subclassed. The Graph.createEdge() method was
deprecated, but GraphImpl still implements the method.
Unless createEdge() is removed from the interface and
any implementation class in the graph package(s), the
warning will occur for any subclass that includes the
Graph interface or any of its derived interfaces in
its "implements" list.

Our code audit requires that no deprecation warnings
exist at release time. The only workaround we have at
this point is to create a copy of the graph package(s)
and modify.

Please either remove the method or remove the
deprecated keyword.

Remove dependency for Log4J

2002-01-01T15:45:26Z

It would be nice if the dependency for Log4J was removed.
The Apache license interferes with the GPL license, i.e.
this is argued by some legal people at Debian. The
CDK project (cdk.sf.net) uses it too... I made a
wrapper (LoggerTool) that uses Log4J is available, and
redirects output to STDOUT if not available. In this
way we can distribute GPLed software without any trouble.
Bug #498302 includes a patch that includes this class
and changes in the OpenJGraph CVS code (of 29 dec)
to use the wrapper instead of Cathegory directly.

I was not able to get XGMML reading completely working
yet, but want to send my patch anyway... Contact me
if you are interested in the patch and want to get
it working in CVS...

Possibility to use other SAX2 parsers

2002-01-01T15:40:33Z

Possibility to use other SAX2 parsers would be a nice
feature, like the GPL Aelfred2.
Since the interface to SAX2 parsers is always identical
this is not hard. Attached is a patch that partly
changes the CVS version for Aelfred2 support.
It also adds a new class LoggerTool that detects if the
Log4J tool is installed, and if not redirects log info
to STDOUT. (Aelfred2 is part of Gnu JAXP:
http://www.gnu.org/software/classpathx/jaxp/\)

Avoid package private visibility

2001-10-25T21:33:42Z

There are several members that have package private
visibility. This makes it cumbersome to use the
member's class as parent class in other packages.

For example, GraphTraversal has a package private
graph attribute but no access methods. A subclass of
GraphTraversal in another package cannot access the
graph attribute, and has to resort to define its own
graph attribute.

It is generally better to use protected visibility
instead of package private, especially if the owning
class is abstract.