Recent changes to bugs

found overlapping data buffer in file player.c

2009-07-27T07:02:55Z

I have scanned the files of mpfc-1.3.7 with the static code analysis tool cppcheck (http://cppcheck.wiki.sourceforge.net/). It found an overlapping data buffer in file player.c at the lines 1401,1403 and 1405.
Lets take a look at the source:
if (player_context->m_bitrate)
sprintf(aparams, "%s%d kbps ", aparams, player_context->m_bitrate);
if (player_context->m_freq)
sprintf(aparams, "%s%d Hz ", aparams, player_context->m_freq);
if (player_context->m_stereo)
sprintf(aparams, "%s%s", aparams,
(player_context->m_stereo == player_context->m_stereo) ? "stereo" : "mono");
wnd_move(wnd, 0, PLAYER_SLIDER_BAL_X - strlen(aparams) - 1,
PLAYER_SLIDER_BAL_Y);

As you can see, the data buffer of aparams overlapps! This is dangerous and can lead to segfaults.

Best regards

Ettl Martin

1.3.4 makes lo-fi streaming music sound like The Chipmunks

2004-11-11T16:29:21Z

When I play low-bandwidth streams (PLS file from bug
1009608), the frequency is messed up. It sounds like
it is playing at 2x normal speed. Local Oggs sound fine.

1.3.4 not happy with audio system on Mandrake 10.1

2004-11-05T04:06:14Z

Compiles without error but when executed:

mpfc: simple.c:1377:
snd_mixer_selem_get_playback_volume_range: Assertion
`elem' failed. Aborted

MPFC hates my low=Fi streaming music

2004-08-15T17:53:39Z

It doesn't like my PLS file format (file attached).
Multiple false tracks are displayed or the last track
is duplicated.

Takes a very long time to start playing.

Seg faults on The Linux Show when they are not
broadcasting.

Refuses to play some streams.

Totem doesn't have any of these problems.

I like MPFC and want to use it on an old PC I plan to
set up as a router. Good combination with Links. The
keyboard layout is a bit odd but it works. How about
mouse support?

Compilation error

2004-01-27T20:48:36Z

I'm having some difficulties compiling MPFC... it gives
the following errors while trying to compile window.c:

window.o(.text+0x9c): In function `wnd_new_root':
/home/clarisse/mpfc-1.1.1/src/window.c:99: undefined
reference to `Gpm_Open'
window.o(.text+0xbe):/home/clarisse/mpfc-1.1.1/src/window.c:105:
undefined reference to `gpm_zerobased'
window.o(.text+0xd2):/home/clarisse/mpfc-1.1.1/src/window.c:105:
undefined reference to `gpm_zerobased'
window.o(.text+0x4d4): In function `wnd_destroy_func':
/home/clarisse/mpfc-1.1.1/src/window.c:249: undefined
reference to `Gpm_Close'
window.o(.text+0x13da): In function `wnd_mouse_handler':
/home/clarisse/mpfc-1.1.1/src/window.c:807: undefined
reference to `_gpm_buf'
window.o(.text+0x13de):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `_gpm_buf'
window.o(.text+0x13e2):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `gpm_zerobased'
window.o(.text+0x13e6):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `gpm_zerobased'
window.o(.text+0x13ea):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `_gpm_arg'
window.o(.text+0x13f2):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `_gpm_buf'
window.o(.text+0x13f6):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `_gpm_arg'
window.o(.text+0x13fa):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `_gpm_buf'
window.o(.text+0x1402):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `gpm_consolefd'
window.o(.text+0x1412):/home/clarisse/mpfc-1.1.1/src/window.c:807:
undefined reference to `gpm_consolefd'
window.o(.text+0x1582): In function `wnd_mouse_thread':
/home/clarisse/mpfc-1.1.1/src/window.c:850: undefined
reference to `gpm_fd'
window.o(.text+0x158a):/home/clarisse/mpfc-1.1.1/src/window.c:855:
undefined reference to `gpm_fd'
window.o(.text+0x15ba):/home/clarisse/mpfc-1.1.1/src/window.c:859:
undefined reference to `gpm_fd'
window.o(.text+0x1604):/home/clarisse/mpfc-1.1.1/src/window.c:865:
undefined reference to `Gpm_GetEvent'
window.o(.text+0x16de): In function `wnd_reinit_mouse':
/home/clarisse/mpfc-1.1.1/src/window.c:895: undefined
reference to `gpm_fd'
window.o(.text+0x16e6):/home/clarisse/mpfc-1.1.1/src/window.c:895:
undefined reference to `gpm_fd'
window.o(.text+0x16f0):/home/clarisse/mpfc-1.1.1/src/window.c:896:
undefined reference to `Gpm_Close'
window.o(.text+0x1728):/home/clarisse/mpfc-1.1.1/src/window.c:903:
undefined reference to `Gpm_Open'
window.o(.text+0x1742):/home/clarisse/mpfc-1.1.1/src/window.c:908:
undefined reference to `gpm_zerobased'
window.o(.text+0x1746):/home/clarisse/mpfc-1.1.1/src/window.c:908:
undefined reference to `gpm_zerobased'
collect2: ld returned 1 exit status
make[3]: *** [mpfc] Error 1
make[3]: Leaving directory `/home/clarisse/mpfc-1.1.1/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/clarisse/mpfc-1.1.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/clarisse/mpfc-1.1.1'
make: *** [all] Error 2

I'm building with GCC 3.3.2 on an 800MHz G4 PowerPC
processor.