Recent changes to bugs

quotes not removed for system literals in public notations

Andrea Goethals — Tue, 27 Jul 2004 21:18:30 -0000

In the NotationReader.readPublicNotation method it
doesn't check for and move past the quotes before
setting the notation's system identifier. It does it
correctly for the public identifier just before setting
the system identitifer in the same method. So as it is
now the quotes are included as part of the notation's
system identifier. I switched this line:

String sysId = data.getNextToken();

in my code to:

quot = data.getNextChar();
if(!isQuotChar(quot)) {
throw new DTDSyntaxException("A system literal
should be enclosed in quotes (\' or \"); found invalid
char - '" + quot + "'.");
}

if( data.endOfData() ) {
throw new DTDSyntaxException("Unexpected end of data
stream encountered at location " +
data.getCurrentLocation() + " - was expecting
notation's system identifier.");
}

String sysId = data.getNextToken(quot); // sysId

---
Andrea

AttList toString bug

Anonymous — Tue, 20 Jul 2004 18:05:03 -0000

I am adapting the Matra code for my own uses and I came
across this bug. In the AttList.toString method (line
323) it has attlist += enums[enums.length - 1] + ") ";

When the enums array is empty this line causes a
java.lang.ArrayIndexOutOfBoundsException to be thrown.
I switched this line in my version of the code to:

if (enums.length > 0) {
attlist += enums[enums.length - 1] + ") ";
} else {
attlist += ") ";
}

Andrea Goethals
goethal@ufl.edu

PubidLiteral not checked for in Notation declaration

derupe — Tue, 23 Mar 2004 00:08:46 -0000

<!NOTATION not PUBLIC "` is not allowed!">
Does not give an error.

PI with invalid target Name

derupe — Mon, 22 Mar 2004 23:44:29 -0000

The PIs do not have a target that follows the 'Name'
construct - so should get an error on parse. Matra does
not throw an error for these.

<?23 name="value"?>
<?1target name="value"?>
<?#target name="value"?>
<? target name="value"?>

Spelling mistake in Notation error message

derupe — Thu, 18 Mar 2004 22:26:57 -0000

Got invalid token while parsing a Notaion declaration
^
It should read Notation not "Notaion".

incorrect error message on eof

derupe — Fri, 30 Jan 2004 23:40:58 -0000

steps to recreate

Matra -s "<"

Caught DTDException - Invalid character (<)
encountered at location (1, 1) - was expecting '!'.

string input referred to as file

derupe — Fri, 30 Jan 2004 23:22:15 -0000

steps to recreate -

Matra -s "<!ELEMENT test EMPTY>"

Completed parsing of DTD the file - <!ELEMENT test
EMPTY>.

Incorrect char in invalid char error

derupe — Fri, 30 Jan 2004 23:16:33 -0000

steps to recreate -

Matra -s "junk"

Caught DTDException - Invalid character (u)
encountered at location (1, 1) - was expecting '<'.

The invalid char here is "j" and not "u"!

Error on valid Notation declaration

derupe — Sun, 25 Jan 2004 21:37:45 -0000

steps to recreate -

Matra -s "<!NOTATION GIF89a PUBLIC '-
//CompuServe//NOTATION Graphics Interchange Format
89a//EN'>"

gives an error! -

Caught DTDException - Got invalid char while parsing a
Notation declaration - I - was expecting '>'.

stacktrace printed even when -v not specified

derupe — Sat, 17 Jan 2004 00:02:50 -0000

When a non-exisiting file location is specified to matra, it
prints the stack trace even if the -v (verbose) option is
not specified.

For e.g.,

Matra -f nofile

gives -

begin parsing ... C:\eclipse\workspace\matra 0_7\nofile
java.io.FileNotFoundException:
C:\eclipse\workspace\matra 0_7\nofile (The system
cannot find the file specified)

Caught DTDException -

Completed parsing of DTD the file -
C:\eclipse\workspace\matra 0_7\nofile.
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.<init>(Unknown
Source)
at java.io.FileInputStream.<init>(Unknown
Source)
at com.conradroche.matra.io.DTDFile.read
(DTDFile.java:145)
at
com.conradroche.matra.dtdparser.DTDParser.parse
(DTDParser.java:516)
at com.conradroche.matra.Matra.process
(Matra.java:281)
at com.conradroche.matra.Matra.main
(Matra.java:225)