jnio2: this passed from constructor

Javier Kohen — Thu, 21 Apr 2005 17:37:57 -0000

In NioSocket's constructor the "this" reference is
passed to the worker's registerChannel method. As the
worker is probably running, this makes it possible for
the NioSocket object to be used before its construction
is complete, which is a very bad idea.

This effect can be minimized by making the
registerChannel call the last in the constructor, but
there are no guarantees that the compiler or JIT won't
rearrange the code, thus brining the bug back.

Besides, the attachment is added to the key after the
call, which even if the call were pulled out of the
constructor, it can cause the attachment to be
referenced by the worker (i.e., from handleRead) before
it's actually attached. This just happened to me, so
it's far from a hypothetical case. However, it's easy
to fix by passing the attachment as a parameter to
registerChannel and using the three-argument form of
SelectableChannel.register that takes the attachment.

In conclusion, there's a bug in the design,
registerChannel must be called from outside the
constructor. I'll post a patch if I fix this myself,
but that might take some time at this point.

jnio2: please recode source to utf-8

Javier Kohen — Wed, 06 Apr 2005 17:32:11 -0000

Hi,

could you please recode the source code from ISO-8859-1
to UTF-8, which is what the toolsets expect? It causes
real trouble with IBM's JDK, which refuses to compile
those files by default. Other JDK's should work as
expected with UTF-8 files, by default.

It's trivial to do with GNU Recode: recode
latin1..utf-8 file.java

Thanks.

PS: contact me for a patch if you don't have access to
GNU Recode.

Recent changes to bugs

jnio2: this passed from constructor

jnio2: please recode source to utf-8