Recent changes to bugs

Since years no new release

Raphael Groner — Sat, 13 Dec 2014 14:37:36 -0000

As discussed somewhere else, you should provide a new main release from the svn trunk.

Please with license headers in each source file. Additionally, you should document demo and test classes. The test is not functional for me, propably cause of some synchronization issue.

We're waiting for an official Fedora 21+ repo package with a current review request.

#6 Missing PayloadType in DataFrame (Fix proposal included)

noamik — Wed, 06 Nov 2013 14:07:10 -0000

status: open --> closed-fixed

#7 Concurrent modification exception when running TestRTPSession.main() [FIX included]

Arne Kepp — Wed, 06 Nov 2013 14:07:09 -0000

status: open --> closed-fixed
assigned_to: noamik

#7 Concurrent modification exception when running TestRTPSession.main() [FIX included]

noamik — Wed, 06 Nov 2013 12:59:48 -0000

Yes, I would be interested in committing fixes directly. I've send a mail already, so you might want to edit and remove your contact information.

#7 Concurrent modification exception when running TestRTPSession.main() [FIX included]

Arne Kepp — Tue, 05 Nov 2013 17:54:15 -0000

Hey,

Looks good. Would you be interested in privileges on the project, so you can commit directly ?

You can email me at arkepp gmail com

-Arne

Concurrent modification exception when running TestRTPSession.main() [FIX included]

noamik — Tue, 05 Nov 2013 17:40:40 -0000

Ticket 7 has been modified: Concurrent modification exception when running TestRTPSession.main() [FIX included]
Edited By: Arne Kepp (arneke)
Status updated: u'open' => u'closed-fixed'
Owner updated: None => u'noamik'

Concurrent modification exception when running TestRTPSession.main() [FIX included]

noamik — Tue, 05 Nov 2013 17:40:40 -0000

The reason is ParticipantDatabase using a LinkedList to store receivers. Changing them to use CopyOnWriteArrayList solves the issue. The new line should look like this:

/** 
 * A copy on write list to hold participants explicitly added by the application
 * In unicast mode this is the list used for RTP and RTCP transmission, 
 * in multicast it should not be in use. 
 */
CopyOnWriteArrayList<Participant> receivers = new CopyOnWriteArrayList<Participant>();

CopyOnWriteArrayLists are a bit slower on modification, but they are thread-safe. Since adding and removing Participants should happen a lot less often then iteration through the list and shouldn't be performance critical, thread safeness should be the priority here IMO.

Missing PayloadType in DataFrame (Fix proposal included)

noamik — Tue, 05 Nov 2013 17:12:21 -0000

Ticket 6 has been modified: Missing PayloadType in DataFrame (Fix proposal included)
Edited By: noamik (noamik)
Status updated: u'open' => u'closed-fixed'

Missing PayloadType in DataFrame (Fix proposal included)

noamik — Tue, 05 Nov 2013 17:12:21 -0000

The DataFrame doesn't set the payload type anywhere.

Proposed fix:
add: "payloadType = aPkt.getPayloadType();" right before doing "lastSeqNum = seqNum[i - 1];" in the DataFrame constructor.

Since all the packets are guaranteed to have the same payloadType, we can savely use the last one processed in the previous loop through all the packets being part of a DataFrame.

Bug in RTPReciverThread.java:128

Anonymous — Sat, 04 Jun 2011 15:47:06 -0000

In the following code, the thread hangs for 10 secs the first time packet.getSocketAddress() is called:

//Find the participant in the database based on SSRC
Participant part = rtpSession.partDb.getParticipant(pktSsrc);

if(part == null) {
InetSocketAddress nullSocket = null;
part = new Participant((InetSocketAddress) packet.getSocketAddress(), nullSocket, pkt.getSsrc());
part.unexpected = true;
rtpSession.partDb.addParticipant(1,part);
}

Thread no longer hangs when I create a new InetSocketAddress instead:

//Find the participant in the database based on SSRC
Participant part = rtpSession.partDb.getParticipant(pktSsrc);

if(part == null) {
InetSocketAddress nullSocket = null;
InetSocketAddress rtpSocket = new InetSocketAddress(packet.getAddress().getHostAddress(), packet.getPort());
part = new Participant(rtpSocket, nullSocket, pkt.getSsrc());
part.unexpected = true;
rtpSession.partDb.addParticipant(1,part);
}