Recent changes to bugs

Wrong Bitrate

Anonymous — Mon, 12 May 2008 12:18:10 -0000

Hello,

I'm trying to use your source.

With every file I try to use I get returned a wrong bitrate.
In order to that a lot of other information are wrong!

What can cause that problem?

Best regards,
Nobody

specific .mp3 causes crash

Anonymous — Thu, 30 Jun 2005 11:16:58 -0000

Hey, I've used v1.0pe4 a bit now, and found a specific
.mp3 that causes it to crash. (The way it crashes is
that the window just disappears, no error message -
this is with the "activate console output..." check box
enabled, so I do have the log if you'd like it.)
v1.0_3 (the java for windows) also crashes, with a
Fatal Exception dialog box - (and on a side-note, I
have to ctrl-alt-delete to get rid of the fatal
exception box...)

(I tried to attach the breaking .mp3 but it's too big -
I can make it available on my website - lemme know)

email: sourceforge at goatwalker dot com

as ever: big thanks for your work!!

jasper

id3v1 version differences fix

Anonymous — Wed, 13 Apr 2005 11:07:10 -0000

When reading an id3v1 tag, the code should check if the
byte directly after the 28th comment byte is truly 0,
else it is probably an id3v1.0 tag. Here is a revised
constructor for the Id3v1Tag class:

public Id3v1Tag(ByteBuffer theBuffer) throws
InstantiationException {

byte[] header = new byte[3];
theBuffer.get(header);

System.out.println(new String(header));
System.out.println("bow" + header[0] + " " +
header[1] + " "
+ header[2]);
System.out.println(Arrays.equals(header, TAG));
if (theBuffer.limit() == 128 &&
Arrays.equals(header, TAG)) {
byte[] tempArray = new byte[FIELD_SIZE];
System.out.println(theBuffer);
theBuffer.get(tempArray);
this.title = new String(tempArray);
theBuffer.get(tempArray);
this.artist = new String(tempArray);
System.out.println(theBuffer);
theBuffer.get(tempArray);
this.album = new String(tempArray);
System.out.println(theBuffer);
tempArray = new byte[4];
theBuffer.get(tempArray);
this.year = new String(tempArray);
System.out.println(theBuffer);
tempArray = new byte[FIELD_SIZE - 2];
theBuffer.get(tempArray);
this.comment = new String(tempArray);

tempArray = new byte[2];
theBuffer.get(tempArray); //get next two bytes
if(tempArray[0]==0){ //if it is 0, we have
a 1.1 tag
this.track = tempArray[1];
tagVersion = "1.1";
} else { //else it is a 1.0 tag, and the
two bytes are part of the comment
this.comment += new String(tempArray);
}
this.genre = theBuffer.get();
System.out.println(theBuffer);

} else {
throw new InstantiationException(
"Cant creat new tag because Tag is
invalid");
}

}

Hope it helps
Cheers

roket.scyntist at gmail dot com

id3v1 genre bug

Anonymous — Wed, 13 Apr 2005 07:59:33 -0000

I discovered that when requesting an id3v1 genre, a
certain range is broken e.g. SynthPop is stored as
decimal 147 in the file, and is also stored as decimal
147 in the string array (NullsoftID3GenreTable.java).
When the library reads the genre, it returns -109
because java uses a signed byte (-128 > 128). If the
number is negative, simply adding 256 should fix the
problem or bit shifting or some other funky method.

Cheers

roket.scyntist at gmail dot com

Unknown ID3v2 Frame Discovered

Andreas Grunewald — Thu, 18 Nov 2004 22:57:35 -0000

Carsten provided a file which throws an Exception
because of an unknown frame. I just want to put the
file into the Bugtracker so that I can keep track of
this problem.

ID3v2ExtendedHeader is busted...

tonyespy — Wed, 28 Apr 2004 23:05:49 -0000

The class ID3v2ExtendedHeader incorrectly uses the
ID3v2.4.0 specification when parsing the bytes of the
extended header. Unfortunately, the ID3v2.3.0 and
ID3v2.4.0 are not compatible in the way they layout the
extended header.

When parsing an MP3 file containing a ID3v2.3.0 tag,
the following exception is thrown:

helliker.id3.ID3v2FormatException: The number of found
flag bytes in the
extende
d header is not equal to the number specified in the
extended header.
at helliker.id3.ID3v2ExtendedHeader.parseFlags
(ID3v2ExtendedHeader.java:
235)
at
helliker.id3.ID3v2ExtendedHeader.readExtendedHeader
(ID3v2ExtendedHead
er.java:197)
at helliker.id3.ID3v2ExtendedHeader.<init>
(ID3v2ExtendedHeader.java:152)

at helliker.id3.ID3v2Tag.<init>(ID3v2Tag.java:150)
at helliker.id3.MP3File.<init>(MP3File.java:203)
at helliker.id3.MP3File.<init>(MP3File.java:150)
at helliker.id3.MP3File.<init>(MP3File.java:130)

I've attached a jar file containing the fixed source
for this problem. It includes IDv2Tag, ID3v2Header,
and ID3v2ExtendedHeader. This code doesn't have too
much testing mileage yet...so far all I've tested is
the read case. I have done no testing of writes...

endless loop in Id3V2.getUpdatePadding

Ron Smits — Mon, 15 Mar 2004 15:33:27 -0000

There is the rare occurrence where an mp3 file will
have Id3V2 compliant padding but no Id3V2 tags. This
will cause the getupdatedPadding method to enter an
endless loop if the new tag is smaller then padding here:

while (newTagSize < size) {
newTagSize += writtenTagSize;
}

Solution is to add before the while loop a test for
writtenTagSize == 0 like this:

if (writtenTagSize == 0) {
newTagSize = sizeDiff * 2;
}

The multiplier by 2 is to make some room :)

ArrayOutOfBoundsException in MP3File.writeTags()

Ron Smits — Sat, 21 Feb 2004 22:13:00 -0000

I found a condition in ID3v2Tag method getbytes where an
ArrayOutOfBoundsException occurs. Now I might be doing
something wrong here :)

Attached is a testcase in jar format. Rename an mp3
file to test.mp3 and run the program twice

Scenario:
Open an mp3 using MP3File remove all the tags and write
new tags. Like
this:

public void save() throws IOException,
NoMPEGFramesException,
ID3v2FormatException,
CorruptHeaderException{
MP3File f = new MP3File (filename,
MP3File.BOTH_TAGS);
f.removeTags(MP3File.EXISTING_TAGS_ONLY);
f.setAlbum (Album);
f.setArtist(Artist);
f.setTitle (Song);
f.writeTags();
}
The class where this is in does NOT go out of scope and
gets called a
second time. The application will crash with the
exception. I added some
debug code around the problem:

if (padding > 0) {
System.err.println ("padding: " + padding+" b: "
+ b.length+" bytesCopied: " + bytesCopied);
System.arraycopy(new byte[padding], 0, b,
bytesCopied, padding);
bytesCopied += padding;
}

This will show:
padding: 16 b: 67 bytesCopied: 67
Apparently it tries to add 16 bytes beyond the allotted
length of the b
[].

MP3File.isMP3() incorrectly identifying files

Anonymous — Thu, 18 Sep 2003 22:31:51 -0000

Scanning some directories for .mp3's using this great
library I noticed that it was incorrectly identifying
many files as .mp3's that were not.

Interestingly, it identifies its own
NullsoftID3GenreTable.class as an MP3.

Doesnt display idv2.4 tags

Anonymous — Tue, 16 Sep 2003 14:46:55 -0000

Tags encoded using EAC and 2,4 dont seem to display,
will support for 2.4 be added.