Add guard for report checkboxes "fields" & "options"

Joël Larose — Tue, 02 Aug 2005 18:34:23 -0000

Group : 4.0.4

The phperror file lists errors relating to "in_array"
having wrong parameter type when called with "fields"
and "options" in the reports page. This would occur
when none of the fields or none of the options is
checked, as is the case for a new report.

The simple fix is to add a guard
"defined($smarty.post.options)" before using the
in_array function.

diff -r themes/default/tpl/reports/client.tpl
/var/www/html/issue-tracker/themes/default/tpl/reports/client.tpl
51c51
< <td width="25%" style="border: none;"><input
type="checkbox" name="fields[]" value="{$field}"{if
in_array($field,$smarty.post.fields)}
checked="checked"{/if} />{$text}</td>
---
> <td width="25%" style="border: none;"><input
type="checkbox" name="fields[]" value="{$field}"{if
defined($smarty.post.fields) &&
in_array($field,$smarty.post.fields)}
checked="checked"{/if} />{$text}</td>
72c72
< <td width="25%" style="border: none;"><input
type="checkbox" name="options[]" value="{$option}"{if
in_array($option,$smarty.post.options)}
checked="checked"{/if} />{$text}</td>
---
> <td width="25%" style="border: none;"><input
type="checkbox" name="options[]" value="{$option}"{if
defined($smarty.post.options) &&
in_array($option,$smarty.post.options)}
checked="checked"{/if} />{$text}</td>

Recent changes to 129: Add guard for report checkboxes "fields" & "options"

Add guard for report checkboxes "fields" & "options"