Recent changes to 129: Add guard for report checkboxes "fields" & "options"https://sourceforge.net/p/issue-tracker/bugs/129/2005-08-02T18:34:23ZRecent changes to 129: Add guard for report checkboxes "fields" & "options"Add guard for report checkboxes "fields" & "options"2005-08-02T18:34:23Z2005-08-02T18:34:23ZJoël Larosehttps://sourceforge.net/u/jplarose/https://sourceforge.net7b0ef3965518722cf43b2117417f862f3189227a<div class="markdown_content"><p>Group : 4.0.4</p>
<p>The phperror file lists errors relating to "in_array"<br />
having wrong parameter type when called with "fields"<br />
and "options" in the reports page. This would occur<br />
when none of the fields or none of the options is<br />
checked, as is the case for a new report.</p>
<p>The simple fix is to add a guard<br />
"defined($smarty.post.options)" before using the<br />
in_array function.</p>
<p>diff -r themes/default/tpl/reports/client.tpl<br />
/var/www/html/issue-tracker/themes/default/tpl/reports/client.tpl<br />
51c51<br />
< <td width="25%" style="border: none;"><input<br />
type="checkbox" name="fields[]" value="{$field}"{if<br />
in_array($field,$smarty.post.fields)}<br />
checked="checked"{/if} />{$text}</td><br />
---<br />
> <td width="25%" style="border: none;"><input<br />
type="checkbox" name="fields[]" value="{$field}"{if<br />
defined($smarty.post.fields) &&<br />
in_array($field,$smarty.post.fields)}<br />
checked="checked"{/if} />{$text}</td><br />
72c72<br />
< <td width="25%" style="border: none;"><input<br />
type="checkbox" name="options[]" value="{$option}"{if<br />
in_array($option,$smarty.post.options)}<br />
checked="checked"{/if} />{$text}</td><br />
---<br />
> <td width="25%" style="border: none;"><input<br />
type="checkbox" name="options[]" value="{$option}"{if<br />
defined($smarty.post.options) &&<br />
in_array($option,$smarty.post.options)}<br />
checked="checked"{/if} />{$text}</td></p></div>