Recent changes to bugs

Tree crashes after server restart

Bas Velthuizen — Thu, 27 Sep 2007 11:08:37 -0000

When the webserver restarts while an echo2 application is active with an active Tree, the Echo2 application crashes when the page is reloaded. This is caused by a nullPointerException in Tree, because the expandedStack and expandedState fields in echopointng.Tree are transient, and thus not set when the Tree is deserialized.

Stack trace is:
java.lang.NullPointerException
at echopointng.Tree.isExpanded(Tree.java:945)
at echopointng.ui.syncpeer.TreeRenderer.renderExpandoCell(TreeRenderer.java:499)
at echopointng.ui.syncpeer.TreeRenderer.renderTreeRow(TreeRenderer.java:754)
at echopointng.ui.syncpeer.TreeRenderer.renderTreeRecursive(TreeRenderer.java:691)
at echopointng.ui.syncpeer.TreeRenderer.renderTree(TreeRenderer.java:708)
at echopointng.ui.syncpeer.TreePeer.renderHtml(TreePeer.java:311)
at echopointng.ui.syncpeer.AbstractEchoPointPeer.renderHtml(AbstractEchoPointPeer.java:298)
at nextapp.echo2.webcontainer.syncpeer.ContentPanePeer.renderChild(ContentPanePeer.java:236)
at nextapp.echo2.webcontainer.syncpeer.ContentPanePeer.renderHtml(ContentPanePeer.java:302)
at nextapp.echo2.webcontainer.syncpeer.ContentPanePeer.renderAdd(ContentPanePeer.java:165)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderChild(SplitPanePeer.java:341)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderAdd(SplitPanePeer.java:288)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderChild(SplitPanePeer.java:341)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderAdd(SplitPanePeer.java:288)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderChild(SplitPanePeer.java:341)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderAdd(SplitPanePeer.java:288)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderChild(SplitPanePeer.java:341)
at nextapp.echo2.webcontainer.syncpeer.SplitPanePeer.renderAdd(SplitPanePeer.java:288)
at nextapp.echo2.webcontainer.syncpeer.ContentPanePeer.renderChild(ContentPanePeer.java:238)
at nextapp.echo2.webcontainer.syncpeer.ContentPanePeer.renderHtml(ContentPanePeer.java:302)
at nextapp.echo2.webcontainer.syncpeer.ContentPanePeer.renderAdd(ContentPanePeer.java:165)
at nextapp.echo2.webcontainer.syncpeer.WindowPeer.renderRefresh(WindowPeer.java:124)
at nextapp.echo2.webcontainer.ContainerSynchronizeService.renderInit(ContainerSynchronizeService.java:427)
at nextapp.echo2.webrender.service.SynchronizeService.service(SynchronizeService.java:269)
at nextapp.echo2.webrender.WebRenderServlet.process(WebRenderServlet.java:273)
at nextapp.echo2.webrender.WebRenderServlet.doPost(WebRenderServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at com.aci.hibernate.HibernateSessionFilter.doFilter(HibernateSessionFilter.java:45)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Unknown Source)

One solution is to check for if transient fields are null in methods like Tree.isExpanded() and Tree.setExpandedState() and if they are null, initialize them.

TreeTable doesn't update (EchoPointNG)

theNTR — Mon, 19 Feb 2007 16:11:58 -0000

The TreeTable component doesn't update when DefaultTreeTableModel's nodesChanged, nodesWereRemoved or nodesWereInserted is called. The TreeTable won't refresh until the user clicks any of the collapse buttons or browser's reload-button.

empty style break style inheritance

Anonymous — Wed, 10 Jan 2007 11:12:38 -0000

In this example MyPane.button inherits background
property and have own foreground. If second style
is empty - it lost background property from base style!

It is very uncomfortable.

I cannot make empty style for changing later.

example:

nextapp.echo2.app.button.AbstractButton#default
{
background : #DDE9FF;
foreground : #000000;
}

nextapp.echo2.app.button.AbstractButton#MyPane.button extends default
{
/* if you remove this property - lost inheritence */
foreground : #FF0000;
}

DefaultProgressBarRenderer - Property Name Mismatch

Benjamin Schmaus — Fri, 23 Jun 2006 18:53:21 -0000

The following code in
'echopointng.progressbar.DefaultProgressBarRenderer'
results in a ClassCastException:

boolean isPainted =
Boolean.TRUE.equals(getRP(pb,ProgressBar.PROPERTY_PROGRESS_STRING_PAINTED,fallbackStyle));
if (isPainted) {
String text = (String)
getRP(pb,ProgressBar.PROPERTY_PROGRESS_STRING_PAINTED,fallbackStyle);
_drawText(g, width, height, text, clrForeGround);
}

I think this code should be written as:

boolean isPainted =
Boolean.TRUE.equals(getRP(pb,ProgressBar.PROPERTY_PROGRESS_STRING_PAINTED,fallbackStyle));
if (isPainted) {
String text = (String)
getRP(pb,ProgressBar.PROPERTY_PROGRESS_STRING,fallbackStyle);
_drawText(g, width, height, text, clrForeGround);
}

Attached is a patch file.

EchopiontNG: PageableTableNavig locks when added in evt hndl

Gabriel Lawrence — Wed, 19 Oct 2005 04:25:39 -0000

In NG fresh from CVS with the echo2 jars as supplied
the PageableTableNavigation seems to trigger the please
wait dialog to appear and lock up. It seems that moving
the init code into the constructor solves this problem
and leaves things working.

So if you delete the init method and change the
constructor to:

public PageableTableNavigation(Table table){
this.model = (PageableTableModel)table.getModel();
doLayout();
}

everything becomes happy.

PageableTableNavigation does not Update

Anonymous — Thu, 29 Sep 2005 16:12:29 -0000

PageableTableNavigation does not update its page count
when the model has data added. It does update the count
if the "next >" button is pushed.

EchopointNG: PushButton CSS bug

Jon Iles — Wed, 07 Sep 2005 12:46:36 -0000

Hi,

adding a style name to PushButton prevents it being
formatted correctly when using CSS. For example,
using the code below:

button1 = new PushButton("Button 1");
button2 = new PushButton("Button 2");
button1.setStyleName("button1");

and a CSS like this:

nextapp.echo2.app.Component
{
font: font(arial,plain,8);
}

button1 will have the correct font, button2 won't.

Cheers!

Jon

EchopointNG: Fix for DefaultTreeCellRenderer CSS problem

Jon Iles — Mon, 05 Sep 2005 15:10:08 -0000

Hi,

I understand that you should be able to apply CSS
styles to the properties of the DefaultTreeCellRenderer
class. This does not appear to work for the current
EchopointNG code in CVS. In order to fix this, two minor
code changes are required:

1. In the Tree.validate method, the statment:

if(!referenceMap.containsKey(child))
this.remove(child);

should be modified to read:

if(!referenceMap.containsKey(child) && child != renderer)
this.remove(child);

to avoid the tree cell renderer from being removed from
the component hierarchy.

2. The DefaultTreeCellRenderer constructor is re-written
as:

public ReportEditorTreeCellRenderer() {
super();

saveBackground = super.getBackground();
saveForeground = super.getForeground();
saveFont = super.getFont();
}

And the
DefaultTreeCellRenderer.getTreeCellRendererText
method is updated to use getRenderProperty to retrieve
the selected foreground, background and font properties.
So the code below:

if (sel) {
super.setForeground(getSelectedForeground());
super.setBackground(getSelectedBackground());
if (getSelectedFont() == null)
super.setFont(tree.getFont());
else
super.setFont(getSelectedFont());

is replaced with the following:

if (sel) {
super.setForeground((Color)getRenderProperty
("selectedForeground"));
super.setBackground((Color)getRenderProperty
("selectedBackground"));
Font selectedFont = (Font)getRenderProperty
("selectedFont");
if (selectedFont == null)
super.setFont(tree.getFont());
else
super.setFont(selectedFont);

With these changes in place, I am now able to add
something like this to my css file:

echopointng.tree.DefaultTreeCellRenderer
{
selectedBackground: white;
selectedForeground: red;
selectedFont: font(arial,bold,10);
}

which now works as expected.

Hope that helps!

Jon

Hourglass.setDelay(int) must be in miliseconds

Eduardo Millan — Tue, 21 Jun 2005 15:04:48 -0000

If you read the echopoint API it says that
setDelay(int) has to be specified in miliseconds. But
if you code it, then you realize that the delay amount
is actually treated as miliseconds.

This bug is intented for the API comment to be fixed.

Double-Checked Locking Trouble with SGMLParser Singleton

Anonymous — Thu, 03 Mar 2005 15:34:44 -0000

I have trouble with HTMLTemplatePanel. After on 1 of 10
restarts of my application i get strange HTML output,
mostly the HTML TemplatePanels are "unparsed" so that
<component> Tags arent replaced.

I guess that an nasty multithread bug exists in the
SGMLPageParser.getInstance() Method:

public static SGMLPageParser getInstance() {
if (sharedInstance == null) {
synchronized (SGMLPageParser.class) {
if (sharedInstance == null)
sharedInstance = new SGMLPageParser();
......
}

Thats look like an Double-Checked Locking bug. For more
information consider:

http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

As workaoround i extend HtmlTemplateLayoutManager and
HtmlTemplateLayoutManagerUI and synchronized the
.compileDataSource() + .render(...) Methodes.

OS: Windows 2000
java version "1.4.2_05"
Java(TM) 2 Runtime Environment, Standard Edition (build
1.4.2_05-b04)
Java HotSpot(TM) Client VM (build 1.4.2_05-b04, mixed mode)