Recent changes to bug-reports

include/extend tags are relative from the current template

Ben — Mon, 06 Sep 2010 16:12:37 -0000

I found this bug by using the extend tag, but assuming it also effects include tag.

When passing the file path to the extend tag, the path is always relative to the template that is currently being processed. This is problematic when rendering templates within sub directories of the template directory.

An example
Consider the following directory structure:
- Templates
|-> layouts
| main.html
|-> blog
| entries.html
`> home.html

When using Dotiac to parse home.html, home.html could use the extends tag to extend layouts/main.html:

{% extends "layouts/main.html" %}

However if you try and do this within blog/entries.html, it will not work because it will in fact try to use blog/layouts/main.html, which does not exist. In django the tags extend and include lookup the paths that they are passed relative to the template directories configured in TEMPLATE_DIRS. This list of directories could be @Dotiac::DTL::TEMPLATE_DIRS, since this is already used when using Dotiac in a django fashion (exported Template and Context).

I have included a svn diff of the changes I have made locally and the test I wrote for it in the hope it helps.

Some background:
I discovered this bug while trying to write a Dotiac renderer for Mojolicious. Mojolicious uses a single directory to store templates, which are typically organised in subfolders for each controller, which inherit from other templates. Currently this is (the simplified) version of that code:

@Dotiac::DTL::TEMPLATE_DIRS = $config{template_paths};
my $template = Dotiac::DTL::Template($template_name);
my $context = Dotiac::DTL::Context({%{$c->stash}, c => $c, h => $helper});
$$output = $template->render($context);

Dokumentation Bug

Anonymous — Mon, 11 Jan 2010 11:24:40 -0000

In section Extension of Dotiac::DTL -> Filters of the main pod the example uses the old syntax.

get_variables() with multiple empty keywords

Maluku — Thu, 05 Feb 2009 18:42:15 -0000

get_variables() does not work right on multiple allowed empty keywords:

{Dotiac::DTL::get_variables("loop foo bar","bar","foo");}
is
{
"" => [
"loop"
],
"foo" => [
"bar"
]
};
not
{
"" => [
"loop"
],
"foo" => [],
"bar" = > []
};
as it should be.

Does not work with perl 5.6.2

Maluku — Mon, 19 Jan 2009 00:19:22 -0000

Fails for various reasons, most of which got to do with time related stuff or wrong modules loaded.

See CPAN-testers

get_variables() warns on undef

Maluku — Fri, 16 Jan 2009 23:24:20 -0000

get_variables() should check for undef as $x, otherwise it will generate useless warnings.

$escape in filter.pm

Maluku — Fri, 16 Jan 2009 23:03:38 -0000

$escape is used instead of a 0 for the autoescape status in filter.pm's print() and string(), but the template-content should always be safe.

It's done right in perlprint() and perlstring()