Recent changes to bugs

test case 30 failure

Anonymous — Fri, 16 May 2008 00:32:47 -0000

Test case 30 fails. Not sure if its our installation but doesn't appear to be the kind of error that would be.

Possible that the severity of the error was changed in recent version.

Version: 0.69
OS: CentOS5 64-bit
HW: AMD 64 X2

------TC53
------TC30 (pause)
--- /tmp/expected.14524 2008-05-15 20:25:53.000000000 -0400
+++ - 2008-05-15 20:25:53.192977000 -0400
@@ -1,3 +1,3 @@
-dktest: DK_STAT_CANTVRFY: Cannot get domain key to verify signature (temporary failure)
+dktest: DK_STAT_NOKEY: No public key available (permanent failure)
Comment: DomainKeys? See http://domainkeys.sourceforge.net/
DomainKey-Status: no key

Unable to install, getting errors, please help

Anonymous — Sat, 20 Jan 2007 20:42:48 -0000

Just downloaded the latest version dk-milter-0.4.1 and tried installing it on a plain RHEL4 box, no control panel, downloaded and untarred the package into /usr/local/src/, but "sh Build" gives the following errors:

cc -O2 -I. -I../../include -I../libdk/ -D_REENTRANT -DXP_MT -c -o dk-filter.o dk-filter.c
dk-filter.c:64:29: libmilter/mfapi.h: No such file or directory
dk-filter.c:172: error: syntax error before "_SOCK_ADDR"
dk-filter.c:172: warning: no semicolon at end of struct or union
dk-filter.c:174: error: syntax error before '}' token
dk-filter.c:192: error: `SMFIS_ACCEPT' undeclared here (not in a function)
dk-filter.c:192: error: initializer element is not constant
dk-filter.c:192: error: (near initialization for `defaults.cfg_nosig')
dk-filter.c:193: error: initializer element is not constant
dk-filter.c:193: error: (near initialization for `defaults.cfg_badsig')
dk-filter.c:194: error: initializer element is not constant
dk-filter.c:194: error: (near initialization for `defaults.cfg_sigmissing')
dk-filter.c:195: error: `SMFIS_TEMPFAIL' undeclared here (not in a function)
dk-filter.c:195: error: initializer element is not constant
dk-filter.c:195: error: (near initialization for `defaults.cfg_dnserr')
dk-filter.c:197: error: initializer element is not constant
dk-filter.c:197: error: (near initialization for `defaults.cfg_internal')
dk-filter.c:245: error: initializer element is not constant
dk-filter.c:245: error: (near initialization for `dkf_values[0].code')
dk-filter.c:245: error: initializer element is not constant
dk-filter.c:245: error: (near initialization for `dkf_values[0]')
dk-filter.c:246: error: initializer element is not constant
dk-filter.c:246: error: (near initialization for `dkf_values[1].code')
dk-filter.c:246: error: initializer element is not constant
dk-filter.c:246: error: (near initialization for `dkf_values[1]')
dk-filter.c:247: error: `SMFIS_DISCARD' undeclared here (not in a function)
dk-filter.c:247: error: initializer element is not constant
dk-filter.c:247: error: (near initialization for `dkf_values[2].code')
dk-filter.c:247: error: initializer element is not constant
dk-filter.c:247: error: (near initialization for `dkf_values[2]')
dk-filter.c:248: error: initializer element is not constant
dk-filter.c:248: error: (near initialization for `dkf_values[3].code')
dk-filter.c:248: error: initializer element is not constant
dk-filter.c:248: error: (near initialization for `dkf_values[3]')
dk-filter.c:249: error: `SMFIS_REJECT' undeclared here (not in a function)
dk-filter.c:249: error: initializer element is not constant
dk-filter.c:249: error: (near initialization for `dkf_values[4].code')
dk-filter.c:249: error: initializer element is not constant
dk-filter.c:249: error: (near initialization for `dkf_values[4]')
dk-filter.c:250: error: initializer element is not constant
dk-filter.c:250: error: (near initialization for `dkf_values[5].code')
dk-filter.c:250: error: initializer element is not constant
dk-filter.c:250: error: (near initialization for `dkf_values[5]')
dk-filter.c:251: error: initializer element is not constant
dk-filter.c:251: error: (near initialization for `dkf_values[6].code')
dk-filter.c:251: error: initializer element is not constant
dk-filter.c:251: error: (near initialization for `dkf_values[6]')
dk-filter.c:252: error: initializer element is not constant
dk-filter.c:252: error: (near initialization for `dkf_values[7].code')
dk-filter.c:252: error: initializer element is not constant
dk-filter.c:252: error: (near initialization for `dkf_values[7]')
dk-filter.c:253: error: initializer element is not constant
dk-filter.c:253: error: (near initialization for `dkf_values[8]')
dk-filter.c:277: error: syntax error before "mlfi_abort"
dk-filter.c:277: error: syntax error before '*' token
dk-filter.c:277: warning: data definition has no type or storage class
dk-filter.c:278: error: syntax error before "mlfi_body"
dk-filter.c:278: error: syntax error before '*' token
dk-filter.c:278: warning: data definition has no type or storage class
dk-filter.c:279: error: syntax error before "mlfi_connect"
dk-filter.c:279: error: syntax error before '*' token
dk-filter.c:279: warning: data definition has no type or storage class
dk-filter.c:280: error: syntax error before "mlfi_envfrom"
dk-filter.c:280: error: syntax error before '*' token
dk-filter.c:280: warning: data definition has no type or storage class
dk-filter.c:281: error: syntax error before "mlfi_envrcpt"
dk-filter.c:281: error: syntax error before '*' token
dk-filter.c:281: warning: data definition has no type or storage class
dk-filter.c:282: error: syntax error before "mlfi_eoh"
dk-filter.c:282: error: syntax error before '*' token
dk-filter.c:282: warning: data definition has no type or storage class
dk-filter.c:283: error: syntax error before "mlfi_eom"
dk-filter.c:283: error: syntax error before '*' token
dk-filter.c:283: warning: data definition has no type or storage class
dk-filter.c:284: error: syntax error before "mlfi_header"
dk-filter.c:284: error: syntax error before '*' token
dk-filter.c:284: warning: data definition has no type or storage class
dk-filter.c:286: error: syntax error before '*' token
dk-filter.c:595: error: syntax error before '*' token
dk-filter.c: In function `dkf_cleanup':
dk-filter.c:601: error: `ctx' undeclared (first use in this function)
dk-filter.c:601: error: (Each undeclared identifier is reported only once
dk-filter.c:601: error: for each function it appears in.)
dk-filter.c:609: error: dereferencing pointer to incomplete type
dk-filter.c:636: error: dereferencing pointer to incomplete type
dk-filter.c: At top level:
dk-filter.c:762: error: syntax error before "dkf_libstatus"
dk-filter.c:762: error: syntax error before '*' token
dk-filter.c: In function `dkf_libstatus':
dk-filter.c:764: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c:769: error: `ctx' undeclared (first use in this function)
dk-filter.c:772: warning: assignment makes pointer from integer without a cast
dk-filter.c:774: error: dereferencing pointer to incomplete type
dk-filter.c:777: error: `status' undeclared (first use in this function)
dk-filter.c:790: error: `where' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:1329: error: syntax error before "mlfi_connect"
dk-filter.c:1329: error: syntax error before '*' token
dk-filter.c: In function `mlfi_connect':
dk-filter.c:1346: error: `host' undeclared (first use in this function)
dk-filter.c:1354: error: `ip' undeclared (first use in this function)
dk-filter.c:1362: error: invalid application of `sizeof' to incomplete type `connctx'
dk-filter.c:1374: error: dereferencing pointer to incomplete type
dk-filter.c:1374: error: dereferencing pointer to incomplete type
dk-filter.c:1384: error: dereferencing pointer to incomplete type
dk-filter.c:1384: error: dereferencing pointer to incomplete type
dk-filter.c:1388: error: dereferencing pointer to incomplete type
dk-filter.c:1388: error: dereferencing pointer to incomplete type
dk-filter.c:1391: error: dereferencing pointer to incomplete type
dk-filter.c:1393: error: `ctx' undeclared (first use in this function)
dk-filter.c:1395: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:1410: error: syntax error before "mlfi_envfrom"
dk-filter.c:1410: error: syntax error before '*' token
dk-filter.c: In function `mlfi_envfrom':
dk-filter.c:1416: error: `ctx' undeclared (first use in this function)
dk-filter.c:1417: error: `envfrom' undeclared (first use in this function)
dk-filter.c:1448: error: dereferencing pointer to incomplete type
dk-filter.c:1454: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:1472: error: syntax error before "mlfi_header"
dk-filter.c:1472: error: syntax error before '*' token
dk-filter.c: In function `mlfi_header':
dk-filter.c:1479: error: `ctx' undeclared (first use in this function)
dk-filter.c:1481: error: `headerf' undeclared (first use in this function)
dk-filter.c:1482: error: `headerv' undeclared (first use in this function)
dk-filter.c:1489: error: dereferencing pointer to incomplete type
dk-filter.c:1538: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:1552: error: syntax error before "mlfi_eoh"
dk-filter.c:1552: error: syntax error before '*' token
dk-filter.c: In function `mlfi_eoh':
dk-filter.c:1568: error: `ctx' undeclared (first use in this function)
dk-filter.c:1576: error: dereferencing pointer to incomplete type
dk-filter.c:1583: warning: assignment makes pointer from integer without a cast
dk-filter.c:1645: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c:1799: warning: assignment makes pointer from integer without a cast
dk-filter.c:1824: warning: assignment makes pointer from integer without a cast
dk-filter.c:1842: warning: assignment makes pointer from integer without a cast
dk-filter.c:1847: error: dereferencing pointer to incomplete type
dk-filter.c:1848: error: dereferencing pointer to incomplete type
dk-filter.c:1851: error: dereferencing pointer to incomplete type
dk-filter.c:1852: error: dereferencing pointer to incomplete type
dk-filter.c:1856: error: dereferencing pointer to incomplete type
dk-filter.c: At top level:
dk-filter.c:2003: error: syntax error before "mlfi_body"
dk-filter.c:2003: error: syntax error before '*' token
dk-filter.c: In function `mlfi_body':
dk-filter.c:2010: error: `ctx' undeclared (first use in this function)
dk-filter.c:2012: error: `bodyp' undeclared (first use in this function)
dk-filter.c:2019: error: dereferencing pointer to incomplete type
dk-filter.c:2026: error: `bodylen' undeclared (first use in this function)
dk-filter.c:2027: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:2049: error: syntax error before "mlfi_eom"
dk-filter.c:2049: error: syntax error before '*' token
dk-filter.c: In function `mlfi_eom':
dk-filter.c:2057: error: `sfsistat' undeclared (first use in this function)
dk-filter.c:2057: error: syntax error before "ret"
dk-filter.c:2068: error: `ctx' undeclared (first use in this function)
dk-filter.c:2076: error: dereferencing pointer to incomplete type
dk-filter.c:2080: warning: assignment makes pointer from integer without a cast
dk-filter.c:2239: error: `MI_FAILURE' undeclared (first use in this function)
dk-filter.c:2346: error: `MI_SUCCESS' undeclared (first use in this function)
dk-filter.c:2360: error: `ret' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:2416: error: syntax error before "mlfi_abort"
dk-filter.c:2416: error: syntax error before '*' token
dk-filter.c: In function `mlfi_abort':
dk-filter.c:2421: error: `ctx' undeclared (first use in this function)
dk-filter.c:2422: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:2436: error: syntax error before "mlfi_close"
dk-filter.c:2436: error: syntax error before '*' token
dk-filter.c: In function `mlfi_close':
dk-filter.c:2441: error: `ctx' undeclared (first use in this function)
dk-filter.c:2459: error: `SMFIS_CONTINUE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:2467: error: variable `smfilter' has initializer but incomplete type
dk-filter.c:2469: warning: excess elements in struct initializer
dk-filter.c:2469: warning: (near initialization for `smfilter')
dk-filter.c:2470: error: `SMFI_VERSION' undeclared here (not in a function)
dk-filter.c:2470: warning: excess elements in struct initializer
dk-filter.c:2470: warning: (near initialization for `smfilter')
dk-filter.c:2471: error: `SMFIF_ADDHDRS' undeclared here (not in a function)
dk-filter.c:2471: error: `SMFIF_CHGHDRS' undeclared here (not in a function)
dk-filter.c:2471: warning: excess elements in struct initializer
dk-filter.c:2471: warning: (near initialization for `smfilter')
dk-filter.c:2472: warning: excess elements in struct initializer
dk-filter.c:2472: warning: (near initialization for `smfilter')
dk-filter.c:2473: warning: excess elements in struct initializer
dk-filter.c:2473: warning: (near initialization for `smfilter')
dk-filter.c:2474: warning: excess elements in struct initializer
dk-filter.c:2474: warning: (near initialization for `smfilter')
dk-filter.c:2475: warning: excess elements in struct initializer
dk-filter.c:2475: warning: (near initialization for `smfilter')
dk-filter.c:2476: warning: excess elements in struct initializer
dk-filter.c:2476: warning: (near initialization for `smfilter')
dk-filter.c:2477: warning: excess elements in struct initializer
dk-filter.c:2477: warning: (near initialization for `smfilter')
dk-filter.c:2478: warning: excess elements in struct initializer
dk-filter.c:2478: warning: (near initialization for `smfilter')
dk-filter.c:2479: warning: excess elements in struct initializer
dk-filter.c:2479: warning: (near initialization for `smfilter')
dk-filter.c:2480: warning: excess elements in struct initializer
dk-filter.c:2480: warning: (near initialization for `smfilter')
dk-filter.c:2481: warning: excess elements in struct initializer
dk-filter.c:2481: warning: (near initialization for `smfilter')
dk-filter.c: In function `main':
dk-filter.c:3795: error: `smfilter' has an incomplete type
dk-filter.c:3795: error: `MI_FAILURE' undeclared (first use in this function)
dk-filter.c: At top level:
dk-filter.c:2467: error: storage size of `smfilter' isn't known
make[1]: *** [dk-filter.o] Error 1
make[1]: Leaving directory `/usr/local/src/dk-milter-0.4.1/obj.Linux.2.6.9-42.0.3.EL.i686/dk-filter'
make: *** [all] Error 2

dk->sender_beforesign not used in dk_address

Sat, 16 Dec 2006 11:19:39 -0000

dk->sender_beforesign is not used in dk_address, if an unsigned message has a Sender: header it will be ignored when dk_address is used to get the sender. When the From: domain requires signing then external verification will fail.

dksign.vcproj missing

Craig Morrison — Tue, 23 May 2006 03:13:32 -0000

dksign.vcproj is missing from the reference
implementation download tarball for building under VC7+
on Windows.

[Patch] dktest goes into infinite loop on some architectures

Anonymous — Sun, 02 Apr 2006 12:33:03 -0000

On some architectures (PowerPC at least -- I think
Sparc might be affected as well), the char type
defaults to unsigned -- therefore the test at line 50
of dktest.c is always false.

Attached is a minimal patch which fixes this exact bug,
but I suspect there might be other related ones....

I'm reachable at : svallet at gmail dot com

Makefile broken - Suggested Patch

Anonymous — Sun, 30 Oct 2005 10:40:39 -0000

Hello Mark / Miles,

I posted this message earlier on the DomainKeys
Implementor's Group on Yahoo and posting it here as
well so that you can take a note of the patch thats
required.

On the fifth Line of Makefile, you need to add
-lresolv, otherwise compilation throws out unknown
symbol error for res_query etc.

It should read as follows :
"LIBS=-L. -ldomainkeys -lcrypto -lresolv"

Currently it is :
"LIBS=-L. -ldomainkeys -lcrypto"

Kindly have the neccesary update made in the next
release or the current release.

Thanks & Regards,
Mitul Limbani,
Founder & CEO,
Enterux Solutions,
The Enterprise Linux Company (TM),
www.enterux.com

current release tar.gz extracts to wrong place

JohnG — Thu, 02 Jun 2005 14:10:42 -0000

Almost every package tar.gz released in the past 5
years extracts into ./<package>-<version>/ however the
current libdomainkeys tar.gz extracts to . potentially
overwriting important files, and generallymaking a mess
of the directory it's extracted into.

UnixWare 7.1.4/Compile error

Larry Rosenman — Thu, 28 Apr 2005 15:40:04 -0000

Larry Rosenman wrote:
> Why doesn't our C compiler (7.1.4MP2) like this?
>
> cc -DBIND_8_COMPAT -g -I. -c dktest.c
> UX:acomp: ERROR: "./domainkeys.h", line 43: Syntax
error before or at: }
> UX:acomp: ERROR: "./domainkeys.h", line 43: cannot
recover from previous
> errors
> *** Error code 1 (bu21)
> UX:make: ERROR: fatal error.

Because it's a syntax error.

C++ permits empty struct/union/class declarations, but
C does not.

41:
42:typedef struct {
43:} DK_LIB;
44:
45:typedef struct {
46:} DK;
47:

dk_from doesn't report the correct value for policy check

Nicolas Hatier — Tue, 08 Mar 2005 17:29:04 -0000

When verifying an email, if the message is not signed,
one may want to verify the domain policy and report an
error if the domain reports a sign-all policy.

When an email is not signed, two things happen.

First, the dk_policy function takes directly the dk->from
value, which is still Fuser@domain. The dk_policy
function should use dk_from() instead.

Second, if there's a sender header in the unsigned
message, this header is not considered since the state
machine is still in the DK_SIGNING_NOVERIFY state,
and the dk_from function will return the From: header of
the message instead of the Sender: header. The
Sender: header should be returned since we want to
check the sender policy.

For instance, I send an email to a mailing list. My server
signs the message. The mailing list takes my message,
modifies it by removing all the "unneeded" headers
(including the signature), and resends it, with the list
address in the Sender header. A domainkeys-verifier
must match the domain policy with the Sender domain,
not with the From: domain.

I implemented a local patch for these two issues, I
remember the pre-signature Sender header in a new
member of the dk struct. When comes the time to
check the policy, if the state machine is still in the
DK_SIGNING_NOVERIFY state, I make the dk_from()
function return the pre-signature sender.

header list (h=) is not created and not evaluated properly

Anonymous — Sat, 01 Jan 2005 01:05:50 -0000

Hi,

I think I found some problem with NOFWS signing messages and created a patch for it.

Explanation

1) a list of headers used to calculate the signature (h=..) should always be created. Lots of mailer daemons, anti-virus scanners and mailing services add additional headers at the end of the list. eg: www.gmx.net and others. If the signature is checked against the altered mail it will certainly fail. So I added proper code and two functions to be able to read a list of headers used to calculate the signature.

2) During my tests validating the sent messages always failed. I found out that validation was successful if the "h=" list was removed. Scrutinizing the code I found the following:
* if a header list is set then this list is looped to find the proper header. these steps are taken:
a) get a header name from the "h=" list ("RECEIVED")
b) start searching for this name in the list of mail headers
c) use the FIRST occurence of this header
d) get back to a

you have a big problem if there are more than one header lines with the same name, as it usually is with "RECEIVED". During verification the first occurence will be used multiple times instead of each one only once. Therefore validation failes.

The solution would be to exchange the loops. Get a mail header line and search for it in the list of headers. Then erase the header name from the header list. I have done that and additionally have rewritten the code to fit into function "dkheaders" instead of "dkheaders_headers".

3) unfortunately there are a lot of mail filters that do not care about the order of the mail header lines. Especially qmail-scanner gives damn about it. If the mail is sent to another mail server using qmail-scanner, the previous "X-Spam-Status" line may be removed and relocated at the top of the mail, with new values. If this header has been used to calculate the signature then verifying the signature fails (of course properly). I think there are a lot more programs that reposition some header lines occasionally. In order to be able to cope with these without reprogramming every of them, the environment variable DKIGNORE is introduced. This contains a list of header names that should not be used for signing, separated by colons ':'. Now "X-Spam-Status" can be ignored when calculating the signature. eg: "X-Spam-Level:X-Spam-Status". Checks are made case insensitive.
I think the DomainKeys draft does not forbid ignoring some header if in "nofws" mode lines and I think it complies with validation standard procedure if a "h=" list of used headers is included in the signature.
To achive this major rewriting of "dkheaders" was necessary.

I have tested the included patch extensively but bugs may still exists. Please drop me a line if you find some.
In case you have any questions or need some further explanations feel free to contact me:
per (dot.) sil (at-@) gmx (dot.) it

Perolo Silantico

PS: Happy new year!!