Recent changes to bugs

#11 Escaped spaces not supported in filename

2017-03-19T21:07:13.344000Z

I rather prevent filenames with spaces, as such add a check for invalid characters in the filename, and if there are reject the file. Or rename the file to only use valid characters.

#14 callflow.php browser interface

2017-03-18T19:12:37.368000Z

Found some issues related to using a pre-defined custom order file, and copying a backup of an order file to final result directory. The former is confusing to the end user when their capture contains more nodes than the pre-defined custom order, and the later prevents the "Default" option from replacing the backed up version on subsequent re-flows if desired.

I plan to rework this, in the meantime in order for the default order file option to override any previously saved order including any pre-defined custom order, create an empty order file and set this as the default.

At CLI:
$ touch empty.order

In callflow.php around line 60 after // Provide a system default node order file
change
$orderFile='';
to
$orderFile="$scriptDir/empty.order";

#11 Escaped spaces not supported in filename

2017-03-18T17:45:50.512000Z

Robert, thank you for the feedback. This is my first open source contribution and I appreciate the opportunity to learn from your comments

Regarding the adjustment to the output directory, I agree this should be a separate patch for a new command line argument, e.g. --outputdir.

The change to the filename alignment was not solely for the case of two nodes; that's simply how the issue first presented itself in my environment. I deal with a lot of very long filenames, which were still being cut off even when more than two nodes were present.

This was elaborated upon in the source comments:

+  # Centering text over a column causes longer filnames to be cut off
+  # when there is less total column width than the lenth of the filename
+  # It's cleaner to left-justify the title by removing the "label" style
+  # and setting a static indent, or center it on half the page width

Adding firewalls is certainly one way to handle that, but I'm doing all that I can to save my end users from editing order files unless absolutely necessary. I'm also trying to keep any middleware as simple as possible by addressing issues within callflow itself.

Perhaps this could become another command line argument, i.e. --titlealign or --titlepos with options for leftmargin, center, default (2nd column).

The most left part of the URI provides the usefull information. As such a width of 250 should be sufficient. In case it is still too small, add firewalls (as explained in the previous item) to obtain a wider diagram.
A better solution might be to be able to specify the width of the diagram on the command line.

The change is simply an increase in the max allowed when specifying the width on the command line:

-  if [[ $OPT_WIDTH_BETWEEN_NODES -gt 250 ]]; then
+  if [[ $OPT_WIDTH_BETWEEN_NODES -gt 1000 ]]; then

Although the leftmost part of the R-URI may be most commonly used, in our environment we deal with very long registration contacts, and I was making room to still see the SDP after that. Also keeping non-technical end users away from the order files.

Adding a line break between the R-URI and the SDP would be another way to keep that tidy.

Saving this for last:

Patch is not needed, when no spaces are used in the filename. Have your web frontend modify the filename, so there are no spaces anymore.

This is not a tenable solution. The issue is not about spaces, this is an issue of properly quoting variables to safely handle user input without unexpected failure. Although not common in Unix-like environments, there are many characters allowed in Windows and Mac environments which will cause scripts to fail when this is not taken into consideration.

I frequently deal with filenames containing characters like "@<>(){}[] and often with justifiable purpose. E.g. capture tools which use the R-UIR, Call-ID, Contact, or To as the filename. Renaming these files breaks continuity with other people involved in the work.

Putting the onus on end users or middleware to only provide "safe" file names forces every other user to solve the problem repeatedly, indefinitely. Adding some quotes to callflow fixes it permanently for all users.

Since I'm starting to get philosophical about this I'll return to the concrete with two things:

http://www.linfo.org/file_name.html Although specific characters are forbidden and others are discouraged, I'm aware of no standard that spaces and other punctuation cannot be used, especially in cross-platform environments like SIP and the Internet where the characters are commonplace in filenames on other platforms.

And more importantly, https://en.wikipedia.org/wiki/Robustness_principle

Be conservative in what you send, be liberal in what you accept

I'll re-post this patch without the un-related changes.

#11 Escaped spaces not supported in filename

2017-03-18T13:34:08.703000Z

Calvin, thanks for the patch. However, do not provide the various changes in one big patch. Provide a patch per related change,please.

Having said that, feedback on your patch:

Prevent spaces to be used in the patch or filename. Using spaces makes processing files only more cumbersome.

Quoting for $inputilfe, $DESTDIR, and others to support spaces and other unfriendly characters in filenames
Where quoting failed, tweaked IFS
Adjusted zip and tar to receive file list from stdin rather than arguments

Patch is not needed, when no spaces are used in the filename. Have your web frontend modify the filename, so there are no spaces anymore.

Adjusted $DESTDIR to exist in current directory, not location of pcap

If you want this, do not change the current behavior. Provide a patch that adds an option that specifies the output directory.

Tweaked alignment of filename title in .svg/.png to tolerate long file name with only two nodes

This is too specific (for two nodes only, normally there are many, many more nodes involved). Add one or more firewalls (in the order file) to the right of the picture, that makes the diagram wider.

If you look in the history, you'll see that the filename location was recently changed to the current location.

Permit wider node width for better display of very long R-URI

The most left part of the URI provides the usefull information. As such a width of 250 should be sufficient. In case it is still too small, add firewalls (as explained in the previous item) to obtain a wider diagram.

A better solution might be to be able to specify the width of the diagram on the command line.

#14 callflow.php browser interface

2017-03-16T22:14:20.696000Z

OK to close this, I just wanted to share in case it was useful to anyone else. I might start a separate sourceforge project if there's enough interest.

#13 No Frame.html generated

2017-03-16T22:01:59.760000Z

Hi Robert,

I believe the issue being reported by Leandro is the message from tshark, not the warning about running as root.

tshark: -o flag "gui.column.format: ..." specifies unknown preference

Older versions of tshark do not have the gui.column.format preference. I experienced the same issue on CentOS 6.5 with TShark 1.8.10.

More recent versions of tshark warn:

Preference "column.format" has been converted to "gui.column.format"

I haven't determined at which version number this behavior changes. It would be nice if callflow could check "tshark -v" and use the version appropriate option, or just use column.format and ignore the warning.

Replacing gui.column.format with column.format resolved the issue. This is part of the patch here: https://sourceforge.net/p/callflow/bugs/11/#d64b

Index: scripts/pcap-parser.sh
===================================================================
--- scripts/pcap-parser.sh      (revision 226)
+++ scripts/pcap-parser.sh      (working copy)
@@ -102,7 +102,7 @@
   # - Megaco has a "|" in its info string, this character is however the
   #   field separator in the output file, remove it.  The actual string
   #   being removed is " |=".
-  tshark -r $PCAP_FILE -t a \
+  tshark -r "$PCAP_FILE" -t a \
     -o 'gui.column.format: "No.", "%m", "Time", %t, "Protocol", "%p", "srcport", %S, "dstport", %D, "Info", "%i"' \
     $FARG "$FVAL" |
       sed -e 's/^[[:blank:]]*//' \

callflow.php browser interface

2017-03-16T02:11:07.718000Z

I've created this PHP front end to callflow.

It depends on the filename quoting and current working directory changes in https://sourceforge.net/p/callflow/bugs/11/#d64b.

It's usable as in include with a CSS wrapper, or standalone. There is a sentinal constant to control whether the script can still be run directly when being included in a wrapper.

#13 No Frame.html generated

2017-03-15T19:59:23.053000Z

status: open --> closed
assigned_to: Richard Bos

#13 No Frame.html generated

2017-03-15T19:59:02.070000Z

Code updated to prevent to run as user root: https://sourceforge.net/p/callflow/code/227/

' # callflow 4126839.pcap
callflow: error: do not run as user 'root'

Update to svn version 227.

#13 No Frame.html generated

2017-03-14T20:12:38.440000Z

tshark: -o flag "gui.column.format: "No.", "%m", "Time", %t, "Protocol", "%p", "srcport", %S, "dstport", %D, "Info", "%i"" specifies unknown preference

Edit bin/callflow and change gui.column.format to column.format, I have the same issue.