Recent changes to bugs

#5 compilation fails with Sun C

2015-07-26T16:35:55.784000Z

status: open --> closed-fixed
Group: --> v1.0 (example)

#6 usleep return value check

2015-07-26T16:35:33.444000Z

status: open --> closed-fixed
Group: --> v1.0 (example)

#8 output the exactly the same name when starting with -Tsum and in "plain" output method

2015-07-26T16:34:43.132000Z

status: open --> closed-fixed

#7 bwm-ng-0.6 fails to build with -Wformat -Wformat-security

2015-07-26T16:34:16.426000Z

labels: --> 0.6.1
status: open --> closed-fixed

output the exactly the same name when starting with -Tsum and in "plain" output method

2014-01-14T06:09:03.189000Z

void print_values(int y,int x,char if_name,t_iface_speed_stats stats,float multiplier,t_iface_stats full_stats) {
...
case PLAIN_OUT:
if (output_method==PLAIN_OUT && ansi_output) printf("\033[%d;2H",y);
printf("%15s:",if_name); / output the name */
printf("%s %s %s\n",
values2str(0,stats,full_stats,multiplier,buffer,49),
values2str(1,stats,full_stats,multiplier,buffer,49),
values2str(2,stats,full_stats,multiplier,buffer,49));

The last "printf" will output 3 data using the same "buffer". Because all 3 data are converted to string and saved in "buffer" one by one, the last data string will overwrite the former ones, and as a result in the final output line there will be 3 numbers which are exactly the same.

output the exactly the same name when starting with -Tsum and in "plain" output method

2014-01-14T06:09:03.189000Z

Ticket 8 has been modified: output the exactly the same name when starting with -Tsum and in "plain" output method
Edited By: vgropp (vgropp)
Status updated: u'open' => u'closed-fixed'

#7 bwm-ng-0.6 fails to build with -Wformat -Wformat-security

2013-12-03T09:20:31.391000Z

Attached patch fixes it.

bwm-ng-0.6 fails to build with -Wformat -Wformat-security

2013-12-03T09:15:14.831000Z

When compiling with -Wformat -Wformat-security (to catch potensial security issues) I get the following error(s):

output.c: In function 'print_header':
output.c:226:13: error: format not a string literal and no format arguments [-Werror=format-security]
             fprintf(tmp_out_file,input2str());
             ^
output.c:227:13: error: format not a string literal and no format arguments [-Werror=format-security]
             fprintf(tmp_out_file,show_all_if2str());
             ^
output.c:237:13: error: format not a string literal and no format arguments [-Werror=format-security]
             printf(input2str());
             ^
output.c: At top level:
cc1: warning: unrecognized command line option "-Wno-long-double" [enabled by default]
cc1: some warnings being treated as errors
Makefile:241: recipe for target 'output.o' failed
make[2]: *** [output.o] Error 1

bwm-ng-0.6 fails to build with -Wformat -Wformat-security

2013-12-03T09:15:14.831000Z

Ticket 7 has been modified: bwm-ng-0.6 fails to build with -Wformat -Wformat-security
Edited By: vgropp (vgropp)
Status updated: u'open' => u'closed-fixed'

usleep return value check

2010-04-21T14:39:08Z

OS: linux mandriva 2009.0
Project version: bwm-ng-0.6
bwm-ng.c:216 if (EINVAL==usleep(delay*1000))
/* there seems to be systems where 1million usecs is max */
usleep(999999);

According to man usleep() possible return values are 0 on success and -1 on error. If the error occures errno is set to EINVAL or EINTR. Linux man seems a bit ambiguity on the case but posix and freebsd man pages states explicitely: "If any of the following conditions occur, the usleep() function shall return -1 and set errno to the corresponding value."

Solution:
if (usleep(delay*1000) != 0)
{
if (errno == EINVAL)
{
errno = 0;
/* there seems to be systems where 1million usecs is max */
usleep(999999);
}
else
{
exit(-1);
}
}