Recent changes to bugshttps://sourceforge.net/p/bartlby/bugs/2008-03-17T09:01:11ZRecent changes to bugsMisusage of "magic numbers"2008-03-17T09:01:11Z2008-03-17T09:01:11ZMarkus Elfringhttps://sourceforge.net/u/elfring/https://sourceforge.net4833935ddb586e5e871c04d353bd71574f338b11<div class="markdown_content"><p>I have seen some fixed integers in a source file.<br />
<a href="http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/config.c?revision=1.12&view=markup">http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/config.c?revision=1.12&view=markup</a></p>
<p>They are unnecessarily hard to understand.<br />
<a href="http://en.wikipedia.org/wiki/Magic_number_%28programming%29#Unnamed_numerical_constant" rel="nofollow">http://en.wikipedia.org/wiki/Magic_number_%28programming%29#Unnamed_numerical_constant</a></p>
<p>I suggest to improve the source code by the use of the sizeof() operator.</p></div>Check return codes everywhere2007-02-27T14:46:11Z2007-02-27T14:46:11ZMarkus Elfringhttps://sourceforge.net/u/elfring/https://sourceforge.netf1d88155c21b2c3560ee24df9b72305b8d99b709<div class="markdown_content"><p>Some checks for return codes are missing.</p>
<p>Examples:<br />
Would you like to add more error handling for return values from "malloc" like in the function "bartlby_check_sirene" and from "fwrite" in the function "bartlby_pre_init"?<br />
<a href="http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/ack.c?revision=1.2&view=markup">http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/ack.c?revision=1.2&view=markup</a><br />
<a href="http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/daemon.c?revision=1.11&view=markup">http://bartlby.cvs.sourceforge.net/bartlby/bartlby-core/src/daemon.c?revision=1.11&view=markup</a></p></div>