serious synchronization bug!

Hi,

I found a serious bug when a stream ends. Actually I
don't understand how no one else had any problems...
After hours of debugging I could finally fix it.

Here is the issue:
DSAudioDevice::update updates all running streams.
This action is synchronized with the scoped lock. If a
stream ends then m_device->fireStopEvent is called
inside DSOutputStream::update.
AbstractDevice::fireStopEvent creates an event with a
reference counted pointer to the stream (m_stream).
Then the event is forwarded to another thread
(m_events_available.notify() in
AbstractDevice::fireStopEvent). The other thread calls
the registered callbacks, where I set the stream to
NULL (in my application). Because the reference count
of the stream is currently 2 (the second reference
from the event) nothing happens except decreasing the
reference count to 1. When the first audiere thread
proceeds and the event instance goes out of scope (in
AbstractDevice::fireStopEvent) the second reference of
the stream is deleted, the reference counter is set to
0 and thus the destructor of the stream is called. In
DSOutputStream::~DSOutputStream the stream is removed
from the device. In DSAudioDevice::removeStream there
is a scoped lock, but this is useless since we are in
the same thread where the lock is first called
(DSAudioDevice::update). Now the stream is actually
deleted although we are still inside
DSOutputStream::update. When leaving this method the
scoped lock is deleted (because it goes out of scope).
But this crashes the application since the stream was
already deleted!

Keep in mind that this problem does not occur
everytime. It depends which thread is faster. e.g. in
which thread the reference count is first decreased to
1.

I hope my explanation was clear enough.
Simple solution to this issue:
change the reference counted pointer in the event
instance to a normal pointer. In class StopEventImpl
change "OutputStreamPtr m_stream" to "OutputStream *
m_stream".

btw, Audiere is great. I hope you can make it more
popular. Maybe you can install a Forum? the mailing
lists are quite hard to use (at least for me).

bye,
Alex