Recent changes to bugs

problem with UTF-16

Anonymous — Mon, 18 May 2009 14:43:22 -0000

Id3v2 tags coded in UTF-16 are not correctly handled. It think that they're threated like coded in UTF-8. It's a real problem, when you use cyrilic letters or some polish.

just for fun: some code cleanups

Bruce Duncan — Mon, 04 May 2009 13:56:00 -0000

I just felt like submitting these. The patch doesn't fix any bugs, but it makes the code simpler and neater IMHO. Do what you like with it.

Please test carefully.

amaKode busy waits with nothing to do

Bruce Duncan — Mon, 04 May 2009 13:51:07 -0000

amaKode uses a polling loop to add new jobs and collect finished ones. It does this even when there is nothing to do. This keeps the processor busy when nothing is happening and makes python appear high on the powertop list of offenders. The attached patch prevents amaKode from polling in this way when there are no active jobs. It waits forever until amarok notifies it of a job.

Please test carefully.

amaKode leaves files open

Bruce Duncan — Mon, 04 May 2009 13:46:20 -0000

amaKode deletes temporary files when it has finished with them, but it keeps the file descriptors open. Thus the files are not deleted from the disc until amaKode is stopped or amarok restarted. The disc can fill up and cause transcoding to fail. The attached patch ensures that all open file descriptors are closed when amaKode is finished with them.

Please test carefully.

m4a to mp3

Anonymous — Sat, 28 Mar 2009 16:40:36 -0000

Recently purchased songs from iTunes includes an atom "----" with some xml that AtomicParsley returns with many lines and they do not begin with "Atom". This causes the amakode.py version 1.8 to choke. I resolved this issue with a very simple change.

diff amakode.py amakode.py.orig
137c137
< if len(fields)==4 and fields[0]=="Atom":
---
> if fields[0]=="Atom":